linux-kernel - Re: [PATCH 2/3] arm64: dts: exynos: gs101: add poweroff node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70846fbb-9c17-440a-911d-456b0444dd94@linaro.org>
Date: Wed, 20 Mar 2024 08:15:41 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, sre@...nel.org,
 robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
 linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
 peter.griffin@...aro.org, robh+dt@...nel.org
Cc: conor+dt@...nel.org, linux-samsung-soc@...r.kernel.org,
 semen.protsenko@...aro.org, linux-kernel@...r.kernel.org,
 klimov.linux@...il.com, kernel-team@...roid.com, tudor.ambarus@...aro.org,
 andre.draszik@...aro.org, saravanak@...gle.com, willmcvicker@...gle.com,
 alim.akhtar@...sung.com, linux-arm-kernel@...ts.infradead.org,
 elder@...aro.org
Subject: Re: [PATCH 2/3] arm64: dts: exynos: gs101: add poweroff node

On 20/03/2024 03:05, Alexey Klimov wrote:
> Signed-off-by: Alexey Klimov <alexey.klimov@...aro.org>
> ---
>  arch/arm64/boot/dts/exynos/google/gs101.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> index 55e6bcb3689e..9def28393274 100644
> --- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> +++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
> @@ -509,6 +509,13 @@ sysreg_apm: syscon@...204e0 {
>  		pmu_system_controller: system-controller@...60000 {
>  			compatible = "google,gs101-pmu", "syscon";
>  			reg = <0x17460000 0x10000>;
> +
> +			poweroff {
> +				compatible = "google,gs101-poweroff";
> +				samsung,syscon-phandle = <&pmu_system_controller>;

This is just senseless... you are the child of pmu, as seen in this DTS.
You do not need to reference yourself (so the PMU)!



Best regards,
Krzysztof