[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4d5b2da7-2a45-4a9f-8a96-a6840d2751a2@linaro.org>
Date: Wed, 20 Mar 2024 08:20:54 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Alexey Klimov <alexey.klimov@...aro.org>, sre@...nel.org,
robh@...nel.org, krzysztof.kozlowski+dt@...aro.org,
linux-pm@...r.kernel.org, devicetree@...r.kernel.org,
peter.griffin@...aro.org, robh+dt@...nel.org
Cc: conor+dt@...nel.org, linux-samsung-soc@...r.kernel.org,
semen.protsenko@...aro.org, linux-kernel@...r.kernel.org,
klimov.linux@...il.com, kernel-team@...roid.com, tudor.ambarus@...aro.org,
andre.draszik@...aro.org, saravanak@...gle.com, willmcvicker@...gle.com,
alim.akhtar@...sung.com, linux-arm-kernel@...ts.infradead.org,
elder@...aro.org
Subject: Re: [PATCH 3/3] power: reset: add new gs101-poweroff driver
On 20/03/2024 03:05, Alexey Klimov wrote:
> +
> + ret = devm_work_autocancel(dev, &gs101->shutdown_work,
> + gs101_shutdown_work_fn);
> + if (ret) {
> + dev_err(dev, "failed to register gs101 shutdown_work: %i\n", ret);
> + unregister_keyboard_notifier(&gs101->keyboard_nb);
> + return ret;
> + }
> +
> + gs101_poweroff_ctx = gs101;
> + platform_set_drvdata(pdev, gs101);
> +
> + /*
> + * At this point there is a chance that psci_sys_poweroff already
> + * registered as pm_power_off hook but unfortunately it cannot power
> + * off the gs101 SoC hence we are rewriting it here just as is.
> + */
> + pm_power_off = gs101_poweroff;
So that's a duplicated syscon power off driver. Why syscon does not
work? syscon_node_to_regmap() does not return correct regmap? If so,
this should be fixed instead of copying the driver with basically only
one difference.
Best regards,
Krzysztof
Powered by blists - more mailing lists