[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <00174dc3-65a7-4a2e-b48d-a974336a3f18@linaro.org>
Date: Thu, 21 Mar 2024 18:53:34 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Wadim Mueller <wafgo01@...il.com>
Cc: Rob Herring <robh+dt@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>,
Pengutronix Kernel Team <kernel@...gutronix.de>,
Fabio Estevam <festevam@...il.com>, NXP Linux Team <linux-imx@....com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Jiri Slaby <jirislaby@...nel.org>, Chester Lin <chester62515@...il.com>,
Andreas Färber <afaerber@...e.de>,
Matthias Brugger <mbrugger@...e.com>, NXP S32 Linux Team <s32@....com>,
Tim Harvey <tharvey@...eworks.com>, Marco Felsch <m.felsch@...gutronix.de>,
Gregor Herburger <gregor.herburger@...tq-group.com>,
Marek Vasut <marex@...x.de>,
Joao Paulo Goncalves <joao.goncalves@...adex.com>,
Markus Niebel <Markus.Niebel@...tq-group.com>,
Matthias Schiffer <matthias.schiffer@...group.com>,
Stefan Wahren <stefan.wahren@...rgebyte.com>,
Bjorn Helgaas <bhelgaas@...gle.com>,
Philippe Schenker <philippe.schenker@...adex.com>,
Yannic Moog <y.moog@...tec.de>, Li Yang <leoyang.li@....com>,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-serial@...r.kernel.org
Subject: Re: [PATCH v3 3/4] dt-bindings: mmc: fsl-imx-esdhc: add NXP S32G3
support
On 21/03/2024 16:41, Wadim Mueller wrote:
> Add a compatible string for the SDHC binding of NXP S32G3 platforms. Here
> we use "nxp,s32g2-usdhc" as fallback since the s32g2-usdhc
> driver works also on S32G3 platforms.
>
> Signed-off-by: Wadim Mueller <wafgo01@...il.com>
> ---
> Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> index 82eb7a24c857..b42b4368fa4e 100644
> --- a/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> +++ b/Documentation/devicetree/bindings/mmc/fsl-imx-esdhc.yaml
> @@ -35,6 +35,7 @@ properties:
> - fsl,imx8mm-usdhc
> - fsl,imxrt1050-usdhc
> - nxp,s32g2-usdhc
> + - nxp,s32g3-usdhc
> - items:
> - const: fsl,imx50-esdhc
> - const: fsl,imx53-esdhc
> @@ -90,6 +91,9 @@ properties:
> - enum:
> - fsl,imxrt1170-usdhc
> - const: fsl,imxrt1050-usdhc
> + - items:
> + - const: nxp,s32g3-usdhc
> + - const: nxp,s32g2-usdhc
No, that's just wrong. G3 is not and is compatible with G2? There is no
dualism here. Either it is or it is not. Not both.
Best regards,
Krzysztof
Powered by blists - more mailing lists