linux-kernel - Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 12:49:20 +0100
From: Heiner Kallweit <hkallweit1@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device
 is powered off

On 20.03.2024 17:32, Andy Shevchenko wrote:
> diff --git a/drivers/dma/idma64.c b/drivers/dma/idma64.c
> index 78a938969d7d..1b60e73d9322 100644
> --- a/drivers/dma/idma64.c
> +++ b/drivers/dma/idma64.c
> @@ -173,6 +173,10 @@ static irqreturn_t idma64_irq(int irq, void *dev)
>  
>  	dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);
>  
> +	/* Since IRQ may be shared, check if DMA controller is powered on */
> +	if (status == GENMASK(31, 0))
> +		return IRQ_NONE;
> +
>  	/* Check if we have any interrupt from the DMA controller */
>  	if (!status)
>  		return IRQ_NONE;
> -- 2.43.0.rc1.1.gbec44491f096

Tested-by: Heiner Kallweit <hkallweit1@...il.com>