linux-kernel - Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device is powered off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zfwh1kte7kAiHD-f@smile.fi.intel.com>
Date: Thu, 21 Mar 2024 14:02:30 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vinod Koul <vkoul@...nel.org>
Subject: Re: [PATCH v1 1/1] idma64: Don't try to serve interrupts when device
 is powered off

On Thu, Mar 21, 2024 at 12:49:20PM +0100, Heiner Kallweit wrote:
> On 20.03.2024 17:32, Andy Shevchenko wrote:

..

> >  	dev_vdbg(idma64->dma.dev, "%s: status=%#x\n", __func__, status);
> >  
> > +	/* Since IRQ may be shared, check if DMA controller is powered on */
> > +	if (status == GENMASK(31, 0))
> > +		return IRQ_NONE;
> > +
> >  	/* Check if we have any interrupt from the DMA controller */
> >  	if (!status)
> >  		return IRQ_NONE;
> > -- 2.43.0.rc1.1.gbec44491f096
> 
> Tested-by: Heiner Kallweit <hkallweit1@...il.com>

Thank you! I think I'll move the test to be before the debug message as it
makes no sense to print when we have powered off device.
Nevertheless, I'll take your tag if no objections for v2.

-- 
With Best Regards,
Andy Shevchenko