linux-kernel - Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d88c05cf-168e-4a0a-90dc-1cb5cb21f120@sirena.org.uk>
Date: Thu, 21 Mar 2024 12:06:05 +0000
From: Mark Brown <broonie@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO
 reset controller

On Thu, Mar 21, 2024 at 12:38:16PM +0100, Krzysztof Kozlowski wrote:
> On 21/03/2024 11:59, Mark Brown wrote:

> > In general the stubs do make sense however in this specific case given
> > that the driver is specifically to control a GPIO rather than using a
> > GPIO along with controlling some other thing a dependency does seem like
> > it makes sense.

> Then you add dependency in wrong place. The warning you have is in:
> drivers/reset/core.o

Note that this isn't a warning but rather a link failure.

> But the dependency you add is in RESET_GPIO, which is a separate driver.
> While the driver indeed wants GPIO, this won't solve the original
> problem. You still can have RESET_GPIO disabled and core still has the
> gpiolib call to missing stub.

That's true, though it does happen to fix the immediate issue and seems
to make sense anyway given that the driver does actually rely on gpiolib
for functionality - it seems clear that there should be a dependency
there independently of the build failure.  Like I say I do agree that a
stub is sensible and you're right that it will fix the underlying issue
behind the build failure.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)