linux-kernel - Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO reset controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <93a6fb3d-b96b-4640-8194-7f778a70fdbe@linaro.org>
Date: Thu, 21 Mar 2024 12:38:16 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mark Brown <broonie@...nel.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>,
 Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] reset: gpio: Fix missing gpiolib dependency for GPIO
 reset controller

On 21/03/2024 11:59, Mark Brown wrote:
> On Thu, Mar 21, 2024 at 08:18:36AM +0100, Krzysztof Kozlowski wrote:
>> On 20/03/2024 20:59, Mark Brown wrote:
> 
>>> The GPIO reset controller uses gpiolib but there is no Kconfig
>>> dependency reflecting this fact, add one.
> 
>> Lack of dependency was intentional: because there is no dependency.
>> GPIOLIB is optional. Because of that I added few stubs for missing
>> GPIOLIB functions, but I missed this stub here.
> 
>> I propose to add gpio_device_find_by_fwnode() stub for !GPIOLIB case,
>> instead of adding dependency.
> 
> In general the stubs do make sense however in this specific case given
> that the driver is specifically to control a GPIO rather than using a
> GPIO along with controlling some other thing a dependency does seem like
> it makes sense.

Then you add dependency in wrong place. The warning you have is in:
drivers/reset/core.o

But the dependency you add is in RESET_GPIO, which is a separate driver.
While the driver indeed wants GPIO, this won't solve the original
problem. You still can have RESET_GPIO disabled and core still has the
gpiolib call to missing stub.

Best regards,
Krzysztof