linux-kernel - Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary static variables it_zero and it_int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 21 Mar 2024 12:38:49 +0100
From: Jan Kara <jack@...e.cz>
To: Joel Granados <j.granados@...sung.com>
Cc: Jan Kara <jack@...e.cz>, wenyang.linux@...mail.com,
	"Eric W . Biederman" <ebiederm@...ssion.com>,
	Luis Chamberlain <mcgrof@...nel.org>,
	Kees Cook <keescook@...omium.org>,
	Christian Brauner <brauner@...nel.org>,
	Dave Young <dyoung@...hat.com>,
	"Darrick J. Wong" <djwong@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH v2 8/9] fs: inotify: delete these unnecessary
 static variables it_zero and it_int_max

On Thu 21-03-24 11:55:55, Joel Granados wrote:
> On Wed, Mar 20, 2024 at 11:36:03AM +0100, Jan Kara wrote:
> > On Tue 19-03-24 23:57:49, wenyang.linux@...mail.com wrote:
> > > From: Wen Yang <wenyang.linux@...mail.com>
> > > 
> > > Delete unnecessary static variables (it_zero and it_int_max)
> > > and encode them directly in the table entry.
> > > 
> > > Signed-off-by: Wen Yang <wenyang.linux@...mail.com>
> > > Cc: Eric W. Biederman <ebiederm@...ssion.com>
> > > Cc: Luis Chamberlain <mcgrof@...nel.org>
> > > Cc: Kees Cook <keescook@...omium.org>
> > > Cc: Joel Granados <j.granados@...sung.com>
> > > Cc: Christian Brauner <brauner@...nel.org>
> > > Cc: Jan Kara <jack@...e.cz>
> > > Cc: "Darrick J. Wong" <djwong@...nel.org>
> > > Cc: linux-kernel@...r.kernel.org
> > 
> > This looks as a sensible cleanup but I don't see the first patch in the
> > series (and neither it is archived at lore.kernel.org) so I cannot really
> > verify whether your conversion is correct...
> This was my original comment. If you want to see the cover letter
> look for this mail ID tencent_06797E65CFC655DCD4F0414B9380E95ECC08@...com
> 
> Not sure why it separates the cover letter from the rest of the patches.

No, that is actually a different email :) Based on lore the message ID
should be:
26c450f6467b4cbaf94cdb10f047abc6ab0c2a5d.1710863674.git.wenyang.linux@...mail.com

but the email is not in the archive...

								Honza
-- 
Jan Kara <jack@...e.com>
SUSE Labs, CR