lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZfxohXDDCx-_cJYa@casper.infradead.org>
Date: Thu, 21 Mar 2024 17:04:05 +0000
From: Matthew Wilcox <willy@...radead.org>
To: Suren Baghdasaryan <surenb@...gle.com>
Cc: akpm@...ux-foundation.org, kent.overstreet@...ux.dev, mhocko@...e.com,
	vbabka@...e.cz, hannes@...xchg.org, roman.gushchin@...ux.dev,
	mgorman@...e.de, dave@...olabs.net, liam.howlett@...cle.com,
	penguin-kernel@...ove.sakura.ne.jp, corbet@....net,
	void@...ifault.com, peterz@...radead.org, juri.lelli@...hat.com,
	catalin.marinas@....com, will@...nel.org, arnd@...db.de,
	tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
	x86@...nel.org, peterx@...hat.com, david@...hat.com,
	axboe@...nel.dk, mcgrof@...nel.org, masahiroy@...nel.org,
	nathan@...nel.org, dennis@...nel.org, jhubbard@...dia.com,
	tj@...nel.org, muchun.song@...ux.dev, rppt@...nel.org,
	paulmck@...nel.org, pasha.tatashin@...een.com,
	yosryahmed@...gle.com, yuzhao@...gle.com, dhowells@...hat.com,
	hughd@...gle.com, andreyknvl@...il.com, keescook@...omium.org,
	ndesaulniers@...gle.com, vvvvvv@...gle.com,
	gregkh@...uxfoundation.org, ebiggers@...gle.com, ytcoode@...il.com,
	vincent.guittot@...aro.org, dietmar.eggemann@....com,
	rostedt@...dmis.org, bsegall@...gle.com, bristot@...hat.com,
	vschneid@...hat.com, cl@...ux.com, penberg@...nel.org,
	iamjoonsoo.kim@....com, 42.hyeyoo@...il.com, glider@...gle.com,
	elver@...gle.com, dvyukov@...gle.com, songmuchun@...edance.com,
	jbaron@...mai.com, aliceryhl@...gle.com, rientjes@...gle.com,
	minchan@...gle.com, kaleshsingh@...gle.com, kernel-team@...roid.com,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	iommu@...ts.linux.dev, linux-arch@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-modules@...r.kernel.org, kasan-dev@...glegroups.com,
	cgroups@...r.kernel.org
Subject: Re: [PATCH v6 20/37] mm: fix non-compound multi-order memory
 accounting in __free_pages

On Thu, Mar 21, 2024 at 04:48:53PM +0000, Matthew Wilcox wrote:
> On Thu, Mar 21, 2024 at 09:36:42AM -0700, Suren Baghdasaryan wrote:
> > +++ b/mm/page_alloc.c
> > @@ -4700,12 +4700,15 @@ void __free_pages(struct page *page, unsigned int order)
> >  {
> >  	/* get PageHead before we drop reference */
> >  	int head = PageHead(page);
> > +	struct alloc_tag *tag = pgalloc_tag_get(page);
> >  
> >  	if (put_page_testzero(page))
> >  		free_the_page(page, order);
> > -	else if (!head)
> > +	else if (!head) {
> > +		pgalloc_tag_sub_pages(tag, (1 << order) - 1);
> >  		while (order-- > 0)
> >  			free_the_page(page + (1 << order), order);
> > +	}
> 
> Why do you need these new functions instead of just:
> 
> +	else if (!head) {
> +		pgalloc_tag_sub(page, (1 << order) - 1);
> 		while (order-- > 0)
> 			free_the_page(page + (1 << order), order);
> +	}

Actually, I'm not sure this is safe (I don't fully understand codetags,
so it may be safe).  What can happen is that the put_page() can come in
before the pgalloc_tag_sub(), and then that page can be allocated again.  
Will that cause confusion?


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ