linux-kernel - Re: [PATCH 5.10 00/73] 5.10.213-rc1 review

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 22 Mar 2024 12:23:43 +0100
From: Marek Vasut <marex@...x.de>
To: Pavel Machek <pavel@...x.de>
Cc: Sasha Levin <sashal@...nel.org>, broonie@...nel.org, tzimmermann@...e.de,
 omosnace@...hat.com, paul@...l-moore.com, yi.zhang@...wei.com, jack@...e.cz,
 tytso@....edu, linux-kernel@...r.kernel.org, stable@...r.kernel.org,
 torvalds@...ux-foundation.org, akpm@...ux-foundation.org,
 linux@...ck-us.net, shuah@...nel.org, patches@...nelci.org,
 lkft-triage@...ts.linaro.org
Subject: Re: [PATCH 5.10 00/73] 5.10.213-rc1 review

On 3/22/24 10:48 AM, Pavel Machek wrote:
> Hi!
> 
>>>> Marek Vasut (1):
>>>>     regmap: Add bulk read/write callbacks into regmap_config
>>>
>>> This one quite intrusive for the stable. Plus, at least "regmap: Add
>>> missing map->bus check" is marked as fixing this one.
>>
>> If there is no very good reason to include that regmap patch in stable
>> backports, I would skip it, it is a feature patch. Does any backport depend
>> on it ?
> 
> Well, yes and no.
> 
> Series of max310x patches depends on it:
> 
> !!a just a preparation; buggy, whole series for fixing this |ef8537927 285e76 o: 5.10| serial: max
> 310x: use regmap methods for SPI batch operations
> 
> ...
> 
> !! whole series to fix corruption, which did not exist in 5.10 in the first place |57871c388 3f42b1 o: 5.10| serial: max310x: fix IO data corruption in batched
> operations
> 
> But according to the 3f42b1, the bug did not exist in 5.10 in the
> first place, so we got buggy 285e76 backported, and then fixes up-to
> 3f42b1 applied to fix it up.

Then probably both max30x patches should be dropped/reverted and the 
regmap bulk callbacks also dropped ?