linux-kernel - Re: [PATCH v2] iio: adc: ad7944: simplify adi,spi-mode property parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zf8_NZ5cNb9TVThx@surfacebook.localdomain>
Date: Sat, 23 Mar 2024 22:44:37 +0200
From: Andy Shevchenko <andy.shevchenko@...il.com>
To: Jonathan Cameron <jic23@...nel.org>
Cc: David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Michael Hennerich <michael.hennerich@...log.com>,
	Nuno Sá <nuno.sa@...log.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: adc: ad7944: simplify adi,spi-mode property
 parsing

Sat, Mar 23, 2024 at 06:29:18PM +0000, Jonathan Cameron kirjoitti:
> On Tue, 19 Mar 2024 10:28:31 -0500
> David Lechner <dlechner@...libre.com> wrote:
> > On Tue, Mar 19, 2024 at 10:01 AM Andy Shevchenko
> > <andy.shevchenko@...il.com> wrote:
> > > On Tue, Mar 19, 2024 at 4:28 PM David Lechner <dlechner@...libre.com> wrote:  

..

> > > > +       ret = device_property_match_property_string(dev, "adi,spi-mode",
> > > > +                                                   ad7944_spi_modes,
> > > > +                                                   ARRAY_SIZE(ad7944_spi_modes));
> > > > +       if (ret < 0) {
> > > > +               if (ret != -EINVAL)
> > > > +                       return dev_err_probe(dev, ret,
> > > > +                                            "getting adi,spi-mode property failed\n");  
> > >  
> > > > -               adc->spi_mode = ret;
> > > > -       } else {  
> > >
> > > Actually we may even leave these unchanged
> > >  
> > > >                 /* absence of adi,spi-mode property means default mode */
> > > >                 adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
> > > > +       } else {
> > > > +               adc->spi_mode = ret;
> > > >         }  
> > >
> > >        ret = device_property_match_property_string(dev, "adi,spi-mode",
> > >                                                    ad7944_spi_modes,
> > >
> > > ARRAY_SIZE(ad7944_spi_modes));
> > >        if (ret >= 0) {
> > >                adc->spi_mode = ret;
> > >        } else if (ret != -EINVAL) {
> > >                        return dev_err_probe(dev, ret,
> > >                                             "getting adi,spi-mode
> > > property failed\n");
> > >        } else {
> > >                /* absence of adi,spi-mode property means default mode */
> > >                adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
> > >        }
> > >
> > > But I can admit this is not an often used approach.
> > >  
> > 
> > I think Jonathan prefers to have the error path first, so I would like
> > to wait and see if he has an opinion here.
> I do prefer error paths first.  Thanks.

Still the above can be refactored to have one line less

	ret = device_property_match_property_string(dev, "adi,spi-mode",
                                                    ad7944_spi_modes,
						    ARRAY_SIZE(ad7944_spi_modes));
	if (ret == -EINVAL) {
		/* absence of adi,spi-mode property means default mode */
		adc->spi_mode = AD7944_SPI_MODE_DEFAULT;
	} else if (ret < 0) {
		return dev_err_probe(dev, ret, "getting adi,spi-mode property failed\n");
	} else {
		adc->spi_mode = ret;
        }

-- 
With Best Regards,
Andy Shevchenko