linux-kernel - Re: [PATCH] hv: vmbus: Convert sprintf() family to sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5c1f6aba-bd3c-438c-8e00-548fe29d8136@fujitsu.com>
Date: Mon, 25 Mar 2024 09:39:52 +0000
From: "Zhijian Li (Fujitsu)" <lizhijian@...itsu.com>
To: Wei Liu <wei.liu@...nel.org>
CC: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "K. Y.
 Srinivasan" <kys@...rosoft.com>, Haiyang Zhang <haiyangz@...rosoft.com>,
	Dexuan Cui <decui@...rosoft.com>, "linux-hyperv@...r.kernel.org"
	<linux-hyperv@...r.kernel.org>
Subject: Re: [PATCH] hv: vmbus: Convert sprintf() family to sysfs_emit()
 family



On 23/03/2024 07:37, Wei Liu wrote:
> Hi Zhijian,
> 
> On Tue, Mar 19, 2024 at 11:43:50AM +0800, Li Zhijian wrote:
>> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
>> or sysfs_emit_at() when formatting the value to be returned to user space.
>>
>> coccinelle complains that there are still a couple of functions that use
>> snprintf(). Convert them to sysfs_emit().
>>
>> sprintf() and scnprintf() will be converted as well if they have.
> 
> This sentence seems to have been cut off halfway. If they have what?

Is it hard to understand, what I want to say is:

Sprintf() and scnprintf() will be converted if these files have such abused cases.

Shall I update it and send a V2?

Thanks
Zhijian



> 
> The code looks fine.
> 
> Thanks,
> Wei.