[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d55f1809-3977-4942-8137-d1fa1895ddf1@linaro.org>
Date: Mon, 25 Mar 2024 09:50:05 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] docs: dt-bindings: add missing address/size-cells to
example
Hi, Krzysztof,
On 3/25/24 09:11, Krzysztof Kozlowski wrote:
> Complete the example of recommended order of properties by adding
> missing address/size-cells. They are not necessary to illustrate the
> style, but lack of them us bit really correct DTS code which might
some typo here
> confuse readers.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
>
> ---
>
> Cc: Tudor Ambarus <tudor.ambarus@...aro.org>
> ---
> Documentation/devicetree/bindings/dts-coding-style.rst | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
> index a9bdd2b59dca..8a68331075a0 100644
> --- a/Documentation/devicetree/bindings/dts-coding-style.rst
> +++ b/Documentation/devicetree/bindings/dts-coding-style.rst
> @@ -144,6 +144,8 @@ Example::
> #dma-cells = <1>;
> clocks = <&clock_controller 0>, <&clock_controller 1>;
> clock-names = "bus", "host";
> + #address-cells = <1>;
> + #size-cells = <1>;
I propose having #address-cells and #size-cells after ranges, because
they are related:
https://devicetree-specification.readthedocs.io/en/stable/devicetree-basics.html#ranges
Looking good:
Reviewed-by: Tudor Ambarus <tudor.ambarus@...aro.org>
> vendor,custom-property = <2>;
> status = "disabled";
>
Powered by blists - more mailing lists