[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <171136379518.1022746.15442509873111996623.kvalo@kernel.org>
Date: Mon, 25 Mar 2024 10:49:56 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: linux-kernel@...r.kernel.org, Li Zhijian <lizhijian@...itsu.com>,
Jeff Johnson <jjohnson@...nel.org>, linux-wireless@...r.kernel.org,
ath11k@...ts.infradead.org, ath10k@...ts.infradead.org
Subject: Re: [PATCH v2 1/3] wifi: ath: Convert sprintf/snprintf to sysfs_emit
Li Zhijian <lizhijian@...itsu.com> wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Kalle Valo <kvalo@...nel.org>
> CC: Jeff Johnson <jjohnson@...nel.org>
> CC: linux-wireless@...r.kernel.org
> CC: ath11k@...ts.infradead.org
> CC: ath10k@...ts.infradead.org
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>
Patch applied to ath-next branch of ath.git, thanks.
fa1a4f15bdca wifi: ath: Convert sprintf/snprintf to sysfs_emit
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-1-lizhijian@fujitsu.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists