[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <171103368135.103792.8592804467389574911.kvalo@kernel.org>
Date: Thu, 21 Mar 2024 15:08:02 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Li Zhijian <lizhijian@...itsu.com>
Cc: linux-kernel@...r.kernel.org, Li Zhijian <lizhijian@...itsu.com>,
Larry Finger <Larry.Finger@...inger.net>, linux-wireless@...r.kernel.org,
b43-dev@...ts.infradead.org
Subject: Re: [PATCH v2 2/3] wifi: b43: Convert sprintf/snprintf to sysfs_emit
Li Zhijian <lizhijian@...itsu.com> wrote:
> Per filesystems/sysfs.rst, show() should only use sysfs_emit()
> or sysfs_emit_at() when formatting the value to be returned to user space.
>
> coccinelle complains that there are still a couple of functions that use
> snprintf(). Convert them to sysfs_emit().
>
> sprintf() will be converted as weel if they have.
>
> Generally, this patch is generated by
> make coccicheck M=<path/to/file> MODE=patch \
> COCCI=scripts/coccinelle/api/device_attr_show.cocci
>
> No functional change intended
>
> CC: Larry Finger <Larry.Finger@...inger.net>
> CC: Kalle Valo <kvalo@...nel.org>
> CC: linux-wireless@...r.kernel.org
> CC: b43-dev@...ts.infradead.org
> Acked-by: Larry Finger <Larry.Finger@...inger.net>
> Signed-off-by: Li Zhijian <lizhijian@...itsu.com>
2 patches applied to wireless-next.git, thanks.
6db5c15c8b6a wifi: b43: Convert sprintf/snprintf to sysfs_emit
48be5774b21b wifi: ti: Convert sprintf/snprintf to sysfs_emit
--
https://patchwork.kernel.org/project/linux-wireless/patch/20240315055211.1347548-2-lizhijian@fujitsu.com/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists