linux-kernel - Re: [PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting code out from crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 25 Mar 2024 09:24:37 +0100
From: Geert Uytterhoeven <geert@...ux-m68k.org>
To: Baoquan He <bhe@...hat.com>
Cc: linux-kernel@...r.kernel.org, kexec@...ts.infradead.org, x86@...nel.org, 
	linux-arm-kernel@...ts.infradead.org, linuxppc-dev@...ts.ozlabs.org, 
	linux-s390@...r.kernel.org, linux-sh@...r.kernel.org, 
	linux-mips@...r.kernel.org, linux-riscv@...ts.infradead.org, 
	loongarch@...ts.linux.dev, akpm@...ux-foundation.org, ebiederm@...ssion.com, 
	hbathini@...ux.ibm.com, piliu@...hat.com, viro@...iv.linux.org.uk
Subject: Re: [PATCH linux-next v3 02/14] crash: split vmcoreinfo exporting
 code out from crash_core.c

Hi Baoquan,

On Wed, Jan 24, 2024 at 6:13 AM Baoquan He <bhe@...hat.com> wrote:
> Now move the relevant codes into separate files:
> kernel/crash_reserve.c, include/linux/crash_reserve.h.
>
> And add config item CRASH_RESERVE to control its enabling.
>
> And also update the old ifdeffery of CONFIG_CRASH_CORE, including of
> <linux/crash_core.h> and config item dependency on CRASH_CORE
> accordingly.
>
> And also do renaming as follows:
>  - arch/xxx/kernel/{crash_core.c => vmcore_info.c}
> because they are only related to vmcoreinfo exporting on x86, arm64,
> riscv.
>
> And also Remove config item CRASH_CORE, and rely on CONFIG_KEXEC_CORE to
> decide if build in crash_core.c.
>
> Signed-off-by: Baoquan He <bhe@...hat.com>
> ---
> v2->v3:
> - There's conflict when rebasing to linux-next in kernel/crash_core.c
>   because of below commits from Uladzislau:
>   commit 699d9351822e ("mm: vmalloc: Fix a warning in the crash_save_vmcoreinfo_init()")
>   commit 5f4c0c1e2a51 (:mm/vmalloc: remove vmap_area_list")

Thanks for your patch, which is now commit 443cbaf9e2fdbef7
("crash: split vmcoreinfo exporting code out from
crash_core.c") in v6.9-rc1.

After this, there are still two references left to CRASH_CORE:

  1. Documentation/admin-guide/kdump/kdump.rst:

         Subsequently, CRASH_CORE is selected by KEXEC_CORE::

  2. arch/loongarch/Kconfig

         config ARCH_HAS_GENERIC_CRASHKERNEL_RESERVATION
             def_bool CRASH_CORE

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68korg

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds