linux-kernel - Re: [PATCH v3 1/4] devcoredump: Add dev_coredump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bab25ec4edd587442a3c14505760d47fa649636.camel@intel.com>
Date: Mon, 25 Mar 2024 18:36:41 +0000
From: "Souza, Jose" <jose.souza@...el.com>
To: "intel-xe@...ts.freedesktop.org" <intel-xe@...ts.freedesktop.org>,
	"johannes@...solutions.net" <johannes@...solutions.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC: "Vivi, Rodrigo" <rodrigo.vivi@...el.com>, "quic_mojha@...cinc.com"
	<quic_mojha@...cinc.com>, "Cavitt, Jonathan" <jonathan.cavitt@...el.com>
Subject: Re: [PATCH v3 1/4] devcoredump: Add dev_coredump_put()

On Mon, 2024-03-25 at 17:48 +0100, Johannes Berg wrote:
> On Mon, 2024-03-04 at 06:39 -0800, José Roberto de Souza wrote:
> > It is useful for modules that do not want to keep coredump available
> > after its unload.
> 
> Why not though? Maybe if this is a common case we should have devm_...
> coredump functions? Dunno.
> 
> Anyway, I'm fine with this, even though I'd like to see a bit more
> discussion than "do not want". Code looks good.
> 
> Reviewed-by: Johannes Berg <johannes@...solutions.net>

Thank you, can you please add this patch to your next pull request? Or should us add it to the next drm/intel-drm pull request?

Again thank you, just this patch will already unblock some work for us.

> 
> johannes