linux-kernel - Re: [RESEND PATCH v2 4/4] iio: adc: rcar-gyroadc: use for_each_available_child_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240325195336.5528172d@jic23-huawei>
Date: Mon, 25 Mar 2024 19:53:36 +0000
From: Jonathan Cameron <jic23@...nel.org>
To: devicetree@...r.kernel.org, linux-iio@...r.kernel.org, Rob Herring
 <robh@...nel.org>, Frank Rowand <frowand.list@...il.com>,
 linux-kernel@...r.kernel.org, Julia Lawall <Julia.Lawall@...ia.fr>
Cc: Peter Zijlstra <peterz@...radead.org>, Andy Shevchenko
 <andriy.shevchenko@...ux.intel.com>, Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>, marek.vasut@...il.com, Jonathan Cameron
 <Jonathan.Cameron@...wei.com>
Subject: Re: [RESEND PATCH v2 4/4] iio: adc: rcar-gyroadc: use
 for_each_available_child_node_scoped()

On Sun, 25 Feb 2024 14:27:14 +0000
Jonathan Cameron <jic23@...nel.org> wrote:

> From: Jonathan Cameron <Jonathan.Cameron@...wei.com>
> 
> Using automated cleanup to replace of_node_put() handling allows for
> a simplfied flow by enabling direct returns on errors.
> 
> Non available child nodes should never have been considered; that
> is ones where status != okay and was defined.
> 
> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>
Applied to the togreg branch of iio.git and pushed out as testing
for all the normal reasons.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/rcar-gyroadc.c | 21 ++++++---------------
>  1 file changed, 6 insertions(+), 15 deletions(-)
> 
> diff --git a/drivers/iio/adc/rcar-gyroadc.c b/drivers/iio/adc/rcar-gyroadc.c
> index d524f2e8e927..15a21d2860e7 100644
> --- a/drivers/iio/adc/rcar-gyroadc.c
> +++ b/drivers/iio/adc/rcar-gyroadc.c
> @@ -318,7 +318,6 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  	struct rcar_gyroadc *priv = iio_priv(indio_dev);
>  	struct device *dev = priv->dev;
>  	struct device_node *np = dev->of_node;
> -	struct device_node *child;
>  	struct regulator *vref;
>  	unsigned int reg;
>  	unsigned int adcmode = -1, childmode;
> @@ -326,7 +325,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  	unsigned int num_channels;
>  	int ret, first = 1;
>  
> -	for_each_child_of_node(np, child) {
> +	for_each_available_child_of_node_scoped(np, child) {
>  		of_id = of_match_node(rcar_gyroadc_child_match, child);
>  		if (!of_id) {
>  			dev_err(dev, "Ignoring unsupported ADC \"%pOFn\".",
> @@ -352,7 +351,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  			num_channels = ARRAY_SIZE(rcar_gyroadc_iio_channels_3);
>  			break;
>  		default:
> -			goto err_e_inval;
> +			return -EINVAL;
>  		}
>  
>  		/*
> @@ -369,7 +368,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  				dev_err(dev,
>  					"Failed to get child reg property of ADC \"%pOFn\".\n",
>  					child);
> -				goto err_of_node_put;
> +				return ret;
>  			}
>  
>  			/* Channel number is too high. */
> @@ -377,7 +376,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  				dev_err(dev,
>  					"Only %i channels supported with %pOFn, but reg = <%i>.\n",
>  					num_channels, child, reg);
> -				goto err_e_inval;
> +				return -EINVAL;
>  			}
>  		}
>  
> @@ -386,7 +385,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  			dev_err(dev,
>  				"Channel %i uses different ADC mode than the rest.\n",
>  				reg);
> -			goto err_e_inval;
> +			return -EINVAL;
>  		}
>  
>  		/* Channel is valid, grab the regulator. */
> @@ -396,8 +395,7 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  		if (IS_ERR(vref)) {
>  			dev_dbg(dev, "Channel %i 'vref' supply not connected.\n",
>  				reg);
> -			ret = PTR_ERR(vref);
> -			goto err_of_node_put;
> +			return PTR_ERR(vref);
>  		}
>  
>  		priv->vref[reg] = vref;
> @@ -422,7 +420,6 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  		 * we can stop parsing here.
>  		 */
>  		if (childmode == RCAR_GYROADC_MODE_SELECT_1_MB88101A) {
> -			of_node_put(child);
>  			break;
>  		}
>  	}
> @@ -433,12 +430,6 @@ static int rcar_gyroadc_parse_subdevs(struct iio_dev *indio_dev)
>  	}
>  
>  	return 0;
> -
> -err_e_inval:
> -	ret = -EINVAL;
> -err_of_node_put:
> -	of_node_put(child);
> -	return ret;
>  }
>  
>  static void rcar_gyroadc_deinit_supplies(struct iio_dev *indio_dev)