[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e396277-f742-41d7-be82-290c0b2368d2@antgroup.com>
Date: Tue, 26 Mar 2024 23:07:11 +0800
From: "Tiwei Bie" <tiwei.btw@...group.com>
To: Lucas De Marchi <lucas.demarchi@...el.com>
Cc: richard@....at, anton.ivanov@...bridgegreys.com,
johannes@...solutions.net, jani.nikula@...el.com,
linux-um@...ts.infradead.org, linux-kernel@...r.kernel.org,
intel-xe@...ts.freedesktop.org
Subject: Re: [PATCH v3 0/9] um: Minor fixes and cleanups
On 3/26/24 10:16 PM, Lucas De Marchi wrote:
> On Tue, Mar 26, 2024 at 08:27:25PM +0800, Tiwei Bie wrote:
>> Hi,
>>
>> Gentle ping.. Please take a look at this series if possible. The changes
>> in this series are very straightforward, so it shouldn't require much effort
>> to review. But they cover a wide area, making them prone to conflicts
>> with other patches :/, e.g.
>>
>> https://lore.kernel.org/linux-um/20240326073750.726636-1-surenb@google.com/T/#u
>>
>> Sorry to be impatient, but pinging this. This series was originally posted
>> two months ago, and hasn't received a review yet. Just want to make sure that
>> this series is not lost..
>>
>> PS. I have tested this series on both of 64bit and 32bit platforms manually.
>> There is also a CI test report from patchwork@...ril.freedesktop.org:
>>
>> https://lore.kernel.org/all/87bk7rzj70.fsf@intel.com/
>
>
> yeah, it's a clear improvement.
>
> For patches 1-5 and 7, feel free to add my Reviewed-by: Lucas De Marchi <lucas.demarchi@...el.com>
> I commented on patch 8 as I'm not sure it's the right approach and same
> thing applies to patch 9. Patch 6 I'm just not sure as it's the first
> time I see that file, so I will leave it to others.
Thanks for the review! I do appreciate it. :)
Regards,
Tiwei
>
> thanks
> Lucas De Marchi
>
>>
>> Thanks,
>> Tiwei
>>
>> On 3/6/24 6:19 PM, Tiwei Bie wrote:
>>> A series of minor fixes and cleanups for UML.
>>>
>>> Most changes in this series are very straightforward. Please consider
>>> picking this series for v6.9.
>>>
>>> There are still some remaining -Wmissing-prototypes warnings. I plan to
>>> send a followup RFC series first to fix those warnings.
>>>
>>> Feedbacks on this series would be appreciated. Thanks!
>>>
>>> Changes since v2:
>>> https://lore.kernel.org/lkml/20240205114708.25235-1-tiwei.btw@antgroup.com/
>>> - Add "um: Move declarations to proper headers";
>>> - Add "um: Fix -Wmissing-prototypes warnings for text_poke*";
>>> - Add "um: Fix -Wmissing-prototypes warnings for __warp_* and foo";
>>> - Make do_set_thread_area() static;
>>> - Add the missing header for calibrate_delay_is_known;
>>>
>>> Tiwei Bie (9):
>>> um: Make local functions and variables static
>>> um: Fix the declaration of vfree
>>> um: Remove unused functions
>>> um: Fix the return type of __switch_to
>>> um: Add missing headers
>>> um: Stop tracking host PID in cpu_tasks
>>> um: Move declarations to proper headers
>>> um: Fix -Wmissing-prototypes warnings for text_poke*
>>> um: Fix -Wmissing-prototypes warnings for __warp_* and foo
>>>
>>> arch/um/drivers/pcap_kern.c | 4 +-
>>> arch/um/drivers/ubd_user.c | 2 +-
>>> arch/um/include/asm/ptrace-generic.h | 3 ++
>>> arch/um/include/shared/as-layout.h | 1 -
>>> arch/um/include/shared/kern_util.h | 1 +
>>> arch/um/include/shared/um_malloc.h | 2 +-
>>> arch/um/kernel/kmsg_dump.c | 2 +-
>>> arch/um/kernel/mem.c | 2 +
>>> arch/um/kernel/physmem.c | 3 +-
>>> arch/um/kernel/process.c | 48 +++++-----------------
>>> arch/um/kernel/ptrace.c | 3 --
>>> arch/um/kernel/reboot.c | 1 +
>>> arch/um/kernel/skas/mmu.c | 1 +
>>> arch/um/kernel/skas/process.c | 5 +--
>>> arch/um/kernel/time.c | 7 ++--
>>> arch/um/kernel/tlb.c | 7 +---
>>> arch/um/kernel/um_arch.c | 1 +
>>> arch/um/kernel/um_arch.h | 2 +
>>> arch/um/os-Linux/drivers/ethertap_kern.c | 2 +-
>>> arch/um/os-Linux/drivers/tuntap_kern.c | 2 +-
>>> arch/um/os-Linux/main.c | 5 +++
>>> arch/um/os-Linux/signal.c | 4 +-
>>> arch/um/os-Linux/start_up.c | 1 +
>>> arch/x86/um/asm/ptrace.h | 6 +++
>>> arch/x86/um/bugs_32.c | 1 +
>>> arch/x86/um/bugs_64.c | 1 +
>>> arch/x86/um/elfcore.c | 1 +
>>> arch/x86/um/fault.c | 1 +
>>> arch/x86/um/os-Linux/mcontext.c | 1 +
>>> arch/x86/um/os-Linux/registers.c | 2 +-
>>> arch/x86/um/os-Linux/tls.c | 1 +
>>> arch/x86/um/ptrace_32.c | 2 -
>>> arch/x86/um/shared/sysdep/kernel-offsets.h | 3 ++
>>> arch/x86/um/tls_32.c | 2 +-
>>> arch/x86/um/user-offsets.c | 3 ++
>>> 35 files changed, 63 insertions(+), 70 deletions(-)
>>>
>>
Powered by blists - more mailing lists