linux-kernel - Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k: describe the ath11k on QCA6390

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 17:12:40 +0200
From: Kalle Valo <kvalo@...nel.org>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Marcel Holtmann <marcel@...tmann.org>,  Luiz Augusto von Dentz
 <luiz.dentz@...il.com>,  "David S . Miller" <davem@...emloft.net>,  Eric
 Dumazet <edumazet@...gle.com>,  Jakub Kicinski <kuba@...nel.org>,  Paolo
 Abeni <pabeni@...hat.com>,  Rob Herring <robh@...nel.org>,  Krzysztof
 Kozlowski <krzysztof.kozlowski+dt@...aro.org>,  Conor Dooley
 <conor+dt@...nel.org>,  Bjorn Andersson <andersson@...nel.org>,  Konrad
 Dybcio <konrad.dybcio@...aro.org>,  Liam Girdwood <lgirdwood@...il.com>,
  Mark Brown <broonie@...nel.org>,  Catalin Marinas
 <catalin.marinas@....com>,  Will Deacon <will@...nel.org>,  Bjorn Helgaas
 <bhelgaas@...gle.com>,  Saravana Kannan <saravanak@...gle.com>,  Geert
 Uytterhoeven <geert+renesas@...der.be>,  Arnd Bergmann <arnd@...db.de>,
  Neil Armstrong <neil.armstrong@...aro.org>,  Marek Szyprowski
 <m.szyprowski@...sung.com>,  Alex Elder <elder@...aro.org>,  Srini
 Kandagatla <srinivas.kandagatla@...aro.org>,  Greg Kroah-Hartman
 <gregkh@...uxfoundation.org>,  Abel Vesa <abel.vesa@...aro.org>,
  Manivannan Sadhasivam <mani@...nel.org>,  Lukas Wunner <lukas@...ner.de>,
  Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
  linux-bluetooth@...r.kernel.org,  netdev@...r.kernel.org,
  devicetree@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-wireless@...r.kernel.org,  linux-arm-msm@...r.kernel.org,
  linux-arm-kernel@...ts.infradead.org,  linux-pci@...r.kernel.org,
  linux-pm@...r.kernel.org,  Bartosz Golaszewski
 <bartosz.golaszewski@...aro.org>,  ath11k@...ts.infradead.org,  Johan
 Hovold <johan@...nel.org>
Subject: Re: [PATCH v6 04/16] dt-bindings: net: wireless: qcom,ath11k:
 describe the ath11k on QCA6390

Bartosz Golaszewski <brgl@...ev.pl> writes:

>> >> I don't know DT well enough to know what the "required:" above means,
>> >> but does this take into account that there are normal "plug&play" type
>> >> of QCA6390 boards as well which don't need any DT settings?
>> >
>> > Do they require a DT node though for some reason?
>>
>> You can attach the device to any PCI slot, connect the WLAN antenna and
>> it just works without DT nodes. I'm trying to make sure here that basic
>> setup still works.
>>
>
> Sure, definitely. I there's no DT node, then the binding doesn't apply
> and the driver (the platform part of it) will not probe.
>
>> Adding also Johan and ath11k list. For example, I don't know what's the
>> plan with Lenovo X13s, will it use this framework? I guess in theory we
>> could have devices which use qcom,ath11k-calibration-variant from DT but
>> not any of these supply properties?
>>
>
> Good point. I will receive the X13s in a month from now. I do plan on
> upstreaming correct support for WLAN and BT for it as well.
>
> I guess we can always relax the requirements once a valid use-case appears?

I think we have such cases already now:

$ git grep ath11k-calibration-variant -- arch
arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:     qcom,ath11k-calibration-variant = "Fairphone_5";
arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts:                     qcom,ath11k-calibration-variant = "LE_X13S";

But please do check that. I'm no DT expert :)

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches