linux-kernel - Re: [PATCH v1 7/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgLm6bIgyTNo-5dy@smile.fi.intel.com>
Date: Tue, 26 Mar 2024 17:16:57 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
Cc: Baojun Xu <baojun.xu@...com>, tiwai@...e.de, robh+dt@...nel.org,
	lgirdwood@...il.com, perex@...ex.cz, kevin-lu@...com,
	13916275206@....com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org, liam.r.girdwood@...el.com,
	yung-chuan.liao@...ux.intel.com, broonie@...nel.org, soyer@....hu
Subject: Re: [PATCH v1 7/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver

On Tue, Mar 26, 2024 at 10:13:06AM -0500, Pierre-Louis Bossart wrote:


..

> memory leaks for each of those goto out;
> 
> You need to use different labels and free-up what was allocated before.

Good point, but better to just use cleanup.h from day 1, it makes this code
shrink even more.

..

> I'll stop the review here.

He-he :-)

-- 
With Best Regards,
Andy Shevchenko