linux-kernel - Re: [PATCH v1 2/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 16:22:35 +0100
From: Takashi Iwai <tiwai@...e.de>
To: Baojun Xu <baojun.xu@...com>
Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	robh+dt@...nel.org,
	lgirdwood@...il.com,
	perex@...ex.cz,
	pierre-louis.bossart@...ux.intel.com,
	kevin-lu@...com,
	13916275206@....com,
	alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org,
	liam.r.girdwood@...el.com,
	yung-chuan.liao@...ux.intel.com,
	broonie@...nel.org,
	soyer@....hu
Subject: Re: [PATCH v1 2/8] ALSA: hda/tas2781: Add tas2781 SPI-based driver

On Tue, 26 Mar 2024 16:00:19 +0100,
Andy Shevchenko wrote:
> 
> On Tue, Mar 26, 2024 at 09:08:59AM +0800, Baojun Xu wrote:
> > Add TXNW2781 support in smi.
> 
> Same comment WRT the commit message.

Yeah, in general, all patches in this series have too short patch
descriptions.

Baojun, please give more words to explain what those patches do, and
more importantly tell why they are needed in that way.  Silence isn't
golden in the case of patches.  So, please resubmit the patch set with
the proper descriptions in each patch.

thanks,

Takashi