linux-kernel - RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 18:09:00 +0000
From: Avri Altman <Avri.Altman@....com>
To: "hch@...radead.org" <hch@...radead.org>, Bart Van Assche
	<bvanassche@....org>
CC: "James E . J . Bottomley" <jejb@...ux.ibm.com>, "Martin K . Petersen"
	<martin.petersen@...cle.com>, Bean Huo <beanhuo@...ron.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions

> On Tue, Mar 26, 2024 at 10:20:13AM -0700, Bart Van Assche wrote:
> > On 3/26/24 01:32, Avri Altman wrote:
> > > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> > >   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> > >   {
> > > -   /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > > -   if (hba->ufs_version <= ufshci_version(1, 1))
> > > -           return UFS_UNIPRO_VER_1_41;
> > > -   else
> > >             return UFS_UNIPRO_VER_1_6;
> > >   }
> >
> > Please fix the indentation of the only remaining return statement in
> > this function.
> 
> Even better just remove the function and use UFS_UNIPRO_VER_1_6 directly
> in the two callers.
Done.

Thanks,
Avri