linux-kernel - RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 18:09:49 +0000
From: Avri Altman <Avri.Altman@....com>
To: Bart Van Assche <bvanassche@....org>, "James E . J . Bottomley"
	<jejb@...ux.ibm.com>, "Martin K . Petersen" <martin.petersen@...cle.com>
CC: Bean Huo <beanhuo@...ron.com>, "linux-scsi@...r.kernel.org"
	<linux-scsi@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] scsi: ufs: Remove support for old UFSHCI versions

> On 3/26/24 01:32, Avri Altman wrote:
> > @@ -992,10 +976,6 @@ EXPORT_SYMBOL_GPL(ufshcd_is_hba_active);
> >
> >   u32 ufshcd_get_local_unipro_ver(struct ufs_hba *hba)
> >   {
> > -     /* HCI version 1.0 and 1.1 supports UniPro 1.41 */
> > -     if (hba->ufs_version <= ufshci_version(1, 1))
> > -             return UFS_UNIPRO_VER_1_41;
> > -     else
> >               return UFS_UNIPRO_VER_1_6;
> >   }
> 
> Please fix the indentation of the only remaining return statement in this
> function.
> 
> > @@ -5565,15 +5524,13 @@ void ufshcd_compl_one_cqe(struct ufs_hba
> *hba, int task_tag,
> >               ufshcd_release_scsi_cmd(hba, lrbp);
> >               /* Do not touch lrbp after scsi done */
> >               scsi_done(cmd);
> > -     } else if (lrbp->command_type == UTP_CMD_TYPE_DEV_MANAGE ||
> > -                lrbp->command_type == UTP_CMD_TYPE_UFS_STORAGE) {
> > -             if (hba->dev_cmd.complete) {
> > -                     if (cqe) {
> > -                             ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> > -                             lrbp->utr_descriptor_ptr->header.ocs = ocs;
> > -                     }
> > -                     complete(hba->dev_cmd.complete);
> > +     } else {
> > +             WARN_ON(!hba->dev_cmd.complete);
> > +             if (cqe) {
> > +                     ocs = le32_to_cpu(cqe->status) & MASK_OCS;
> > +                     lrbp->utr_descriptor_ptr->header.ocs = ocs;
> >               }
> > +             complete(hba->dev_cmd.complete);
> >       }
> >   }
> 
> The above is a functional change that has not been mentioned in the patch
> description. Please undo the functional change or explain in the patch
> description why this is considered correct.
Will make note of that in the commit log.

Thanks,
Avri

> 
> Thanks,
> 
> Bart.