linux-kernel - Re: [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiDSCuc2AKqhAXBq6tmxZ0oK2WamuSOwJJ4qFBrJ56w8_9JKA@mail.gmail.com>
Date: Tue, 26 Mar 2024 09:49:52 +0100
From: Ricardo Ribalda <ribalda@...omium.org>
To: Sergey Senozhatsky <senozhatsky@...omium.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>, Guenter Roeck <linux@...ck-us.net>, 
	Max Staudt <mstaudt@...omium.org>, Tomasz Figa <tfiga@...omium.org>, 
	Laurent Pinchart <laurent.pinchart@...asonboard.com>, Alan Stern <stern@...land.harvard.edu>, 
	Hans Verkuil <hverkuil-cisco@...all.nl>, linux-media@...r.kernel.org, 
	linux-kernel@...r.kernel.org, Sean Paul <seanpaul@...omium.org>, 
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API

Hi Sergey

On Tue, 26 Mar 2024 at 09:42, Sergey Senozhatsky
<senozhatsky@...omium.org> wrote:
>
> On (24/03/25 16:31), Ricardo Ribalda wrote:
> >  drivers/media/usb/uvc/uvc_driver.c | 13 ++-------
> >  drivers/media/usb/uvc/uvc_status.c | 57 ++++++++++++++++++++++++++++++++++++--
> >  drivers/media/usb/uvc/uvc_v4l2.c   | 22 ++++-----------
> >  drivers/media/usb/uvc/uvcvideo.h   | 10 ++++---
> >  4 files changed, 68 insertions(+), 34 deletions(-)
> >
> > diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
> > index 17fc945c8deb6..b579644ac0745 100644
> > --- a/drivers/media/usb/uvc/uvc_driver.c
> > +++ b/drivers/media/usb/uvc/uvc_driver.c
> > @@ -2116,7 +2116,6 @@ static int uvc_probe(struct usb_interface *intf,
> >       INIT_LIST_HEAD(&dev->streams);
> >       kref_init(&dev->ref);
> >       atomic_set(&dev->nmappings, 0);
> > -     mutex_init(&dev->lock);
>
> Where is this getting initialized?

in uvc_status_init((). It is now called status_lock

But it should be init before  (ep == NULL)... otherwise it will not
work in devices without the int_ep.

Let me send a new version

Thanks!




--
Ricardo Ribalda