linux-kernel - Re: [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240326085925.GC1041856@google.com>
Date: Tue, 26 Mar 2024 17:59:25 +0900
From: Sergey Senozhatsky <senozhatsky@...omium.org>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Guenter Roeck <linux@...ck-us.net>,
	Max Staudt <mstaudt@...omium.org>, Tomasz Figa <tfiga@...omium.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Alan Stern <stern@...land.harvard.edu>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sean Paul <seanpaul@...omium.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>
Subject: Re: [PATCH v3 2/3] media: uvcvideo: Refactor the status irq API

On (24/03/25 16:31), Ricardo Ribalda wrote:
>  
>  void uvc_status_unregister(struct uvc_device *dev)
>  {
> -	usb_kill_urb(dev->int_urb);
> +	uvc_status_suspend(dev);
>  	uvc_input_unregister(dev);
>  }


Was the removal of usb_kill_urb() intended? If so, does it deserve
to be a patch on its own?