linux-kernel - Re: [PATCH] driver core: Remove unused platform_notify, platform_notify

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 12:05:15 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Bjorn Helgaas <helgaas@...nel.org>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Rafael J . Wysocki" <rafael@...nel.org>, 
	linux-kernel@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, 
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, 
	Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] driver core: Remove unused platform_notify, platform_notify_remove

On Mon, Mar 25, 2024 at 11:14 PM Bjorn Helgaas <helgaas@...nel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@...gle.com>
>
> The "platform_notify" and "platform_notify_remove" hooks have been unused
> since 00ba9357d189 ("ARM: ixp4xx: Drop custom DMA coherency and bouncing").
>
> Remove "platform_notify" and "platform_notify_remove".  No functional
> change intended.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@...gle.com>
> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Cc: Linus Walleij <linus.walleij@...aro.org>

Acked-by: Rafael J. Wysocki <rafael@...nel.org>

> ---
>  drivers/base/core.c    |  8 --------
>  include/linux/device.h | 11 -----------
>  2 files changed, 19 deletions(-)
>
> diff --git a/drivers/base/core.c b/drivers/base/core.c
> index b93f3c5716ae..78dfa74ee18b 100644
> --- a/drivers/base/core.c
> +++ b/drivers/base/core.c
> @@ -2331,8 +2331,6 @@ static void fw_devlink_link_device(struct device *dev)
>
>  /* Device links support end. */
>
> -int (*platform_notify)(struct device *dev) = NULL;
> -int (*platform_notify_remove)(struct device *dev) = NULL;
>  static struct kobject *dev_kobj;
>
>  /* /sys/dev/char */
> @@ -2380,16 +2378,10 @@ static void device_platform_notify(struct device *dev)
>         acpi_device_notify(dev);
>
>         software_node_notify(dev);
> -
> -       if (platform_notify)
> -               platform_notify(dev);
>  }
>
>  static void device_platform_notify_remove(struct device *dev)
>  {
> -       if (platform_notify_remove)
> -               platform_notify_remove(dev);
> -
>         software_node_notify_remove(dev);
>
>         acpi_device_notify_remove(dev);
> diff --git a/include/linux/device.h b/include/linux/device.h
> index 97c4b046c09d..c515ba5756e4 100644
> --- a/include/linux/device.h
> +++ b/include/linux/device.h
> @@ -1206,17 +1206,6 @@ int __must_check devm_device_add_groups(struct device *dev,
>  int __must_check devm_device_add_group(struct device *dev,
>                                        const struct attribute_group *grp);
>
> -/*
> - * Platform "fixup" functions - allow the platform to have their say
> - * about devices and actions that the general device layer doesn't
> - * know about.
> - */
> -/* Notify platform of device discovery */
> -extern int (*platform_notify)(struct device *dev);
> -
> -extern int (*platform_notify_remove)(struct device *dev);
> -
> -
>  /*
>   * get_device - atomically increment the reference count for the device.
>   *
> --
> 2.34.1
>