linux-kernel - Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 26 Mar 2024 14:05:11 +0000
From: "Landge, Sudan" <sudanl@...zon.co.uk>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>, kernel test robot
	<lkp@...el.com>, Sudan Landge <sudanl@...zon.com>, <tytso@....edu>,
	<Jason@...c4.com>, <robh+dt@...nel.org>, <krzysztof.kozlowski+dt@...aro.org>,
	<conor+dt@...nel.org>, <sathyanarayanan.kuppuswamy@...ux.intel.com>,
	<thomas.lendacky@....com>, <dan.j.williams@...el.com>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC: <oe-kbuild-all@...ts.linux.dev>, <graf@...zon.de>, <dwmw@...zon.co.uk>,
	<bchalios@...zon.es>, <xmarcalx@...zon.co.uk>
Subject: Re: [PATCH v3 4/4] virt: vmgenid: add support for devicetree bindings



On 26/03/2024 12:53, Krzysztof Kozlowski wrote:
> CAUTION: This email originated from outside of the organization. Do not click links or open attachments unless you can confirm the sender and know the content is safe.
> 
> 
> 
> On 26/03/2024 13:48, kernel test robot wrote:
>> Hi Sudan,
>>
>> kernel test robot noticed the following build errors:
> 
> ...
> 
>>     134                ret = setup_vmgenid_state(state, remapped_ptr);
>>     135                if (ret)
>>     136                        goto out;
>>     137
>>     138                state->irq = platform_get_irq(pdev, 0);
>>     139                if (state->irq < 0) {
>>     140                        ret = state->irq;
>>     141                        goto out;
>>     142                }
>>     143                pdev->dev.driver_data = state;
>>     144
>>     145                ret =  devm_request_irq(&pdev->dev, state->irq,
>>     146                                        vmgenid_of_irq_handler,
>>     147                                        IRQF_SHARED, "vmgenid", &pdev->dev);
>>     148                if (ret)
>>     149                        pdev->dev.driver_data = NULL;
>>     150
>>     151        out:
>>     152                return ret;
>>     153        #else
>>   > 154                (void)dev;
> 
> So this code was not even built...
> 
> Best regards,
> Krzysztof
> 
I built it with CONFIG_ACPI and CONFIG_OF enabled but missed to build it 
without the CONFIG_OF flag. As mentioned in the other mail I'll make 
sure to run all required tools and check for all combinations before 
posting future patches.