linux-kernel - Re: [PATCH] ath10k: allocate dummy net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 27 Mar 2024 09:17:08 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jeff Johnson <quic_jjohnson@...cinc.com>
Cc: Breno Leitao <leitao@...ian.org>, Kalle Valo <kvalo@...nel.org>, Jeff
 Johnson <jjohnson@...nel.org>, <keescook@...omium.org>, "open
 list:NETWORKING DRIVERS (WIRELESS)" <linux-wireless@...r.kernel.org>, "open
 list:QUALCOMM ATHEROS ATH10K WIRELESS DRIVER" <ath10k@...ts.infradead.org>,
 open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ath10k: allocate dummy net_device dynamically

On Wed, 27 Mar 2024 08:42:55 -0700 Jeff Johnson wrote:
> On 3/27/2024 7:45 AM, Jakub Kicinski wrote:
> > On Wed, 27 Mar 2024 07:38:05 -0700 Breno Leitao wrote:  
> >>   -void init_dummy_netdev(struct net_device *dev)
> >>   +void init_dummy_netdev_core(struct net_device *dev)  
> > 
> > Can init_dummy_netdev_core() be a static function (and no export)?
> > alloc_netdev_dummy() is probably going to be the only user.
> > 
> > I'd also lean towards squashing the two commits into one.  
> 
> And once all of the conversions are complete, won't init_dummy_netdev() no
> longer be used and can be removed?

That's right, it should be removed. But it may take another release
cycle until we can do that, depending on how quickly the patches
propagate :(