linux-kernel - Re: [PATCH v1 2/2] ASoC: qcom: qcm6490: Add machine driver for qcm6490

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 27 Mar 2024 13:22:19 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Mohammad Rafi Shaik <quic_mohs@...cinc.com>,
 srinivas.kandagatla@...aro.org, bgoswami@...cinc.com, broonie@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, andersson@...nel.org,
 konrad.dybcio@...aro.org, lgirdwood@...il.com, tiwai@...e.com,
 quic_rohkumar@...cinc.com, linux-kernel@...r.kernel.org,
 alsa-devel@...a-project.org, linux-sound@...r.kernel.org,
 linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v1 2/2] ASoC: qcom: qcm6490: Add machine driver for
 qcm6490

On 27/03/2024 12:32, Mohammad Rafi Shaik wrote:
> +
> +static int qcm6490_snd_hw_free(struct snd_pcm_substream *substream)
> +{
> +	struct snd_soc_pcm_runtime *rtd = substream->private_data;
> +	struct qcm6490_snd_data *data = snd_soc_card_get_drvdata(rtd->card);
> +	struct snd_soc_dai *cpu_dai = snd_soc_rtd_to_cpu(rtd, 0);
> +	struct sdw_stream_runtime *sruntime = data->sruntime[cpu_dai->id];
> +
> +	return qcom_snd_sdw_hw_free(substream, sruntime,
> +				    &data->stream_prepared[cpu_dai->id]);
> +}
> +
> +static const struct snd_soc_ops qcm6490_be_ops = {
> +	.hw_params = qcm6490_snd_hw_params,
> +	.hw_free = qcm6490_snd_hw_free,
> +	.prepare = qcm6490_snd_prepare,
> +};

I think you leak sdw_stream, because of missing shutdown.

Except that everything looks like sc8280xp, except the snd_init(), so I
wonder how important that difference is? Cannot be combined into sc8280xp?

Best regards,
Krzysztof