linux-kernel - Re: [RFC PATCH v5 0/6] TPEBS counting mode support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM9d7ci+8m1-Hcm9OjkaLk4ZOs6J0ah+pg0phyQGA_HVX9Qb-A@mail.gmail.com>
Date: Thu, 28 Mar 2024 12:43:24 -0700
From: Namhyung Kim <namhyung@...nel.org>
To: Ian Rogers <irogers@...gle.com>
Cc: weilin.wang@...el.com, Arnaldo Carvalho de Melo <acme@...nel.org>, 
	Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>, 
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Jiri Olsa <jolsa@...nel.org>, 
	Adrian Hunter <adrian.hunter@...el.com>, Kan Liang <kan.liang@...ux.intel.com>, 
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org, 
	Perry Taylor <perry.taylor@...el.com>, Samantha Alt <samantha.alt@...el.com>, 
	Caleb Biggers <caleb.biggers@...el.com>
Subject: Re: [RFC PATCH v5 0/6] TPEBS counting mode support

Hello,

On Thu, Mar 28, 2024 at 9:36 AM Ian Rogers <irogers@...gle.com> wrote:
>
> On Tue, Mar 26, 2024 at 1:29 PM <weilin.wang@...el.com> wrote:
> >
> > From: Weilin Wang <weilin.wang@...el.com>
> >
> > Changes in v5:
> > - Update code and add comments for better code quality [Ian]
> >
> > v4: https://lore.kernel.org/all/20240312234921.812685-1-weilin.wang@intel.com/
> >
> > Weilin Wang (6):
> >   perf stat: Parse and find tpebs events when parsing metrics to prepare
> >     for perf record sampling
> >   perf stat: Fork and launch perf record when perf stat needs to get
> >     retire latency value for a metric.
> >   perf stat: Add retire latency values into the expr_parse_ctx to
> >     prepare for final metric calculation
> >   perf stat: Create another thread for sample data processing
> >   perf stat: Add retire latency print functions to print out at the very
> >     end of print out
> >   perf vendor events intel: Add MTL metric json files
> >
> >  tools/perf/builtin-stat.c                     |  211 +-
> >  .../arch/x86/meteorlake/metricgroups.json     |  127 +
> >  .../arch/x86/meteorlake/mtl-metrics.json      | 2551 +++++++++++++++++
> >  tools/perf/util/data.c                        |    3 +
> >  tools/perf/util/data.h                        |    5 +
> >  tools/perf/util/metricgroup.c                 |   88 +-
> >  tools/perf/util/metricgroup.h                 |   22 +-
> >  tools/perf/util/stat-display.c                |   65 +
> >  tools/perf/util/stat-shadow.c                 |   19 +
> >  tools/perf/util/stat.h                        |    4 +
> >  10 files changed, 3076 insertions(+), 19 deletions(-)
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/metricgroups.json
> >  create mode 100644 tools/perf/pmu-events/arch/x86/meteorlake/mtl-metrics.json
>
> Thanks Weilin,
>
> I'm happy with this series, my Reviewed-by is on all the patches.
> Arnaldo/Namhyung, could we land this for the sake of Meteorlake metric
> enablement? For the sake of tools, for the series:
>
> Reviewed-by: Ian Rogers <irogers@...gle.com>

Let me review this series again.

Thanks,
Namhyung