linux-kernel - Re: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 29 Mar 2024 00:20:31 +0100
From: Werner Sembach <wse@...edocomputers.com>
To: Luiz Augusto von Dentz <luiz.dentz@...il.com>
Cc: Marcel Holtmann <marcel@...tmann.org>, Christoffer Sandberg
 <cs@...edo.de>, linux-bluetooth@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Bluetooth: btintel: Add devices to
 HCI_QUIRK_BROKEN_LE_CODED

Hi Luiz,

Am 28.03.24 um 15:17 schrieb Luiz Augusto von Dentz:
> Hi Werner,
>
> On Thu, Mar 28, 2024 at 9:18 AM Werner Sembach <wse@...edocomputers.com> wrote:
>> From: Christoffer Sandberg <cs@...edo.de>
>>
>> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
>> connection issues when enabled. This patch disables it through
>> the existing quirk.
>>
>> Signed-off-by: Christoffer Sandberg <cs@...edo.de>
>> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
>> Cc: <stable@...r.kernel.org>
>> ---
>>   drivers/bluetooth/btintel.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
>> index cdc5c08824a0a..6dbfb74d0adf9 100644
>> --- a/drivers/bluetooth/btintel.c
>> +++ b/drivers/bluetooth/btintel.c
>> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
>>          case 0x17:
>>          case 0x18:
>>          case 0x19:
>> +               /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
>> +               set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> If it is just these 3 then we are missing a break here.

The cases are not added by the patch, the fallthrough was here before. This 
patch just adds this quirk for these 3 cases on top to the other things done 
below, aka the fallthrough is intentional.

Best regards,

Werner

>
>>          case 0x1b:
>>          case 0x1c:
>>                  /* Display version information of TLV type */
>> --
>> 2.34.1
>>
>