linux-kernel - RE: [PATCH] Bluetooth: btintel: Add devices to HCI_QUIRK_BROKEN_LE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB758500838CD30B3F0BFB8397F5382@PH0PR11MB7585.namprd11.prod.outlook.com>
Date: Sun, 31 Mar 2024 04:52:13 +0000
From: "K, Kiran" <kiran.k@...el.com>
To: Werner Sembach <wse@...edocomputers.com>, Marcel Holtmann
	<marcel@...tmann.org>, Luiz Augusto von Dentz <luiz.dentz@...il.com>
CC: Christoffer Sandberg <cs@...edo.de>, "linux-bluetooth@...r.kernel.org"
	<linux-bluetooth@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] Bluetooth: btintel: Add devices to
 HCI_QUIRK_BROKEN_LE_CODED

Hi Werner,

> -----Original Message-----
> From: Werner Sembach <wse@...edocomputers.com>
> Sent: Thursday, March 28, 2024 6:48 PM
> To: Marcel Holtmann <marcel@...tmann.org>; Luiz Augusto von Dentz
> <luiz.dentz@...il.com>
> Cc: Christoffer Sandberg <cs@...edo.de>; Werner Sembach
> <wse@...edocomputers.com>; linux-bluetooth@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Subject: [PATCH] Bluetooth: btintel: Add devices to
> HCI_QUIRK_BROKEN_LE_CODED
> 
> From: Christoffer Sandberg <cs@...edo.de>
> 
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through the existing
> quirk.
> 
Do see this issue with latest firmware ?  Can you please share the firmware version you are using (share dmesg on system boot) ?

> Signed-off-by: Christoffer Sandberg <cs@...edo.de>
> Signed-off-by: Werner Sembach <wse@...edocomputers.com>
> Cc: <stable@...r.kernel.org>
> ---
>  drivers/bluetooth/btintel.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c index
> cdc5c08824a0a..6dbfb74d0adf9 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,8 @@ static int btintel_setup_combined(struct hci_dev
> *hdev)
>  	case 0x17:
>  	case 0x18:
>  	case 0x19:
> +		/* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is
> enabled */
> +		set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
>  	case 0x1b:
>  	case 0x1c:
>  		/* Display version information of TLV type */
> --
> 2.34.1
> 

Thanks,
Kiran