linux-kernel - Re: [PATCH 5.10 005/238] btrfs: add and use helper to check if block group is used

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgVFkYnPf9aLeFFM@duo.ucw.cz>
Date: Thu, 28 Mar 2024 11:25:21 +0100
From: Pavel Machek <pavel@...x.de>
To: David Sterba <dsterba@...e.cz>
Cc: Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, Filipe Manana <fdmanana@...e.com>,
	Johannes Thumshirn <johannes.thumshirn@....com>,
	Josef Bacik <josef@...icpanda.com>, Boris Burkov <boris@....io>,
	David Sterba <dsterba@...e.com>
Subject: Re: [PATCH 5.10 005/238] btrfs: add and use helper to check if block
 group is used

Hi!

> > From: Filipe Manana <fdmanana@...e.com>
> > 
> > [ Upstream commit 1693d5442c458ae8d5b0d58463b873cd879569ed ]
> > 
> > Add a helper function to determine if a block group is being used and make
> > use of it at btrfs_delete_unused_bgs(). This helper will also be used in
> > future code changes.
> > 
> > Reviewed-by: Johannes Thumshirn <johannes.thumshirn@....com>
> > Reviewed-by: Josef Bacik <josef@...icpanda.com>
> > Reviewed-by: Boris Burkov <boris@....io>
> > Signed-off-by: Filipe Manana <fdmanana@...e.com>
> > Reviewed-by: David Sterba <dsterba@...e.com>
> > Signed-off-by: David Sterba <dsterba@...e.com>
> > Signed-off-by: Sasha Levin <sashal@...nel.org>
> 
> Please drop this patch from all stable branches unless it's a
> prerequisite for some other patch. This is clearly a cleanup.

This was reported multiple times, and you have even said you have
dropped the patch. What went wrong here?

Best regards,
								Pavel

Date: Mon, 18 Mar 2024 10:18:36 -0400
From: Sasha Levin <sashal@...nel.org>
Subject: Re: [PATCH AUTOSEL 5.10 1/7] btrfs: add and use helper to check if block group is used

On Mon, Mar 11, 2024 at 10:05:40PM +0100, David Sterba wrote:
> On Mon, Mar 11, 2024 at 10:00:43PM +0100, Pavel Machek wrote:
> > Hi!
> >
> > > From: Filipe Manana <fdmanana@...e.com>
> > >
> > > [ Upstream commit 1693d5442c458ae8d5b0d58463b873cd879569ed ]
> > >
> > > Add a helper function to determine if a block group is being used and make
> > > use of it at btrfs_delete_unused_bgs(). This helper will also be used in
> > > future code changes.
> >
> > Does not fix a bug and does not seem to be preparation for anything,
> > so probably should not be here.
>
> Agreed, this patch does not belong to stable and I objected in
> https://lore.kernel.org/all/20240229155207.GA2604@suse.cz/
>
> for version 6.7 and all other stable versions.

Dropped, thanks!

--
Thanks,
Sasha

-- 
DENX Software Engineering GmbH,        Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

Download attachment "signature.asc" of type "application/pgp-signature" (196 bytes)