linux-kernel - Re: [PATCH] bpf, sockmap: fix deadlock in rcu_report_exp_cpu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <j6tugwevw3vrcnbf4zxa6apdq4twtmqkdvdj3ndjajajnvltnv@n2cvevln6dvx>
Date: Fri, 29 Mar 2024 23:52:31 +0800
From: Shung-Hsi Yu <shung-hsi.yu@...e.com>
To: Jakub Sitnicki <jakub@...udflare.com>
Cc: Alexei Starovoitov <alexei.starovoitov@...il.com>, 
	Edward Adam Davis <eadavis@...com>, John Fastabend <john.fastabend@...il.com>, 
	syzbot+c4f4d25859c2e5859988@...kaller.appspotmail.com, 42.hyeyoo@...il.com, andrii@...nel.org, ast@...nel.org, 
	bpf@...r.kernel.org, daniel@...earbox.net, davem@...emloft.net, edumazet@...gle.com, 
	kafai@...com, kpsingh@...nel.org, kuba@...nel.org, 
	linux-kernel@...r.kernel.org, namhyung@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com, 
	peterz@...radead.org, songliubraving@...com, syzkaller-bugs@...glegroups.com, 
	yhs@...com, Xin Liu <liuxin350@...wei.com>
Subject: Re: [PATCH] bpf, sockmap: fix deadlock in rcu_report_exp_cpu_mult

On Tue, Mar 26, 2024 at 11:15:47PM +0100, Jakub Sitnicki wrote:
> On Mon, Mar 25, 2024 at 01:23 PM +01, Jakub Sitnicki wrote:
> > On Sat, Mar 23, 2024 at 12:08 AM -07, Alexei Starovoitov wrote:
> >> It seems this bug was causing multiple syzbot reports.
> > Any chance we could disallow mutating sockhash from interrupt context?
> 
> I've been playing with the repro from one of the other reports:
> 
> https://lore.kernel.org/all/CABOYnLzaRiZ+M1v7dPaeObnj_=S4JYmWbgrXaYsyBbWh=553vQ@mail.gmail.com/

Possibly also related:
- "A potential deadlock in sockhash map"[1] report awhile back
- commit ed17aa92dc56b ("bpf, sockmap: fix deadlocks in the sockhash and
  sockmap")
- commit 8c5c2a4898e3d ("bpf, sockmap: Revert buggy deadlock fix in the
  sockhash and sockmap")

1: https://lore.kernel.org/all/CABcoxUayum5oOqFMMqAeWuS8+EzojquSOSyDA3J_2omY=2EeAg@mail.gmail.com/