linux-kernel - Re: [PATCH 4/7] wifi: ath10k: sdio: drop driver owner initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8ba398c9-b71c-4447-a1d0-bd560e41f39f@quicinc.com>
Date: Fri, 29 Mar 2024 16:22:32 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Ulf Hansson
	<ulf.hansson@...aro.org>,
        Marcel Holtmann <marcel@...tmann.org>,
        Luiz Augusto
 von Dentz <luiz.dentz@...il.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
        Kalle
 Valo <kvalo@...nel.org>, Jeff Johnson <jjohnson@...nel.org>,
        Arend van Spriel
	<arend.vanspriel@...adcom.com>,
        Brian Norris <briannorris@...omium.org>,
        Jérôme Pouiller <jerome.pouiller@...abs.com>
CC: <linux-mmc@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-bluetooth@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>, <linux-wireless@...r.kernel.org>,
        <ath10k@...ts.infradead.org>, <brcm80211@...ts.linux.dev>,
        <brcm80211-dev-list.pdl@...adcom.com>
Subject: Re: [PATCH 4/7] wifi: ath10k: sdio: drop driver owner initialization

On 3/29/2024 10:24 AM, Krzysztof Kozlowski wrote:
> Core in sdio_register_driver() already sets the .owner, so driver does
> not need to.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Acked-by: Jeff Johnson <quic_jjohnson@...cinc.com>

> 
> ---
> 
> Depends on the first patch.
> ---
>  drivers/net/wireless/ath/ath10k/sdio.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
> index 1acb9fba9a8e..cddd9e3010ee 100644
> --- a/drivers/net/wireless/ath/ath10k/sdio.c
> +++ b/drivers/net/wireless/ath/ath10k/sdio.c
> @@ -2667,7 +2667,6 @@ static struct sdio_driver ath10k_sdio_driver = {
>  	.probe = ath10k_sdio_probe,
>  	.remove = ath10k_sdio_remove,
>  	.drv = {
> -		.owner = THIS_MODULE,
>  		.pm = ATH10K_SDIO_PM_OPS,
>  	},
>  };
>