linux-kernel - Re: [PATCH v19 095/130] KVM: VMX: Modify NMI and INTR handlers to take intr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZgYthRHalTwRm6AT@chao-email>
Date: Fri, 29 Mar 2024 10:55:01 +0800
From: Chao Gao <chao.gao@...el.com>
To: <isaku.yamahata@...el.com>
CC: <kvm@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<isaku.yamahata@...il.com>, Paolo Bonzini <pbonzini@...hat.com>,
	<erdemaktas@...gle.com>, Sean Christopherson <seanjc@...gle.com>, Sagi Shahar
	<sagis@...gle.com>, Kai Huang <kai.huang@...el.com>, <chen.bo@...el.com>,
	<hang.yuan@...el.com>, <tina.zhang@...el.com>, Sean Christopherson
	<sean.j.christopherson@...el.com>
Subject: Re: [PATCH v19 095/130] KVM: VMX: Modify NMI and INTR handlers to
 take intr_info as function argument

On Mon, Feb 26, 2024 at 12:26:37AM -0800, isaku.yamahata@...el.com wrote:
>From: Sean Christopherson <sean.j.christopherson@...el.com>
>
>TDX uses different ABI to get information about VM exit.  Pass intr_info to
>the NMI and INTR handlers instead of pulling it from vcpu_vmx in
>preparation for sharing the bulk of the handlers with TDX.
>
>When the guest TD exits to VMM, RAX holds status and exit reason, RCX holds
>exit qualification etc rather than the VMCS fields because VMM doesn't have
>access to the VMCS.  The eventual code will be
>
>VMX:
>  - get exit reason, intr_info, exit_qualification, and etc from VMCS
>  - call NMI/INTR handlers (common code)
>
>TDX:
>  - get exit reason, intr_info, exit_qualification, and etc from guest
>    registers
>  - call NMI/INTR handlers (common code)
>
>Signed-off-by: Sean Christopherson <sean.j.christopherson@...el.com>
>Signed-off-by: Isaku Yamahata <isaku.yamahata@...el.com>
>Reviewed-by: Paolo Bonzini <pbonzini@...hat.com>

Reviewed-by: Chao Gao <chao.gao@...el.com>