linux-kernel - Re: [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zgpf0rqUSEZcSiAV@sunil-laptop>
Date: Mon, 1 Apr 2024 12:48:42 +0530
From: Sunil V L <sunilvl@...tanamicro.com>
To: Haibo Xu <haibo1.xu@...el.com>
Cc: xiaobo55x@...il.com, ajones@...tanamicro.com,
	Paul Walmsley <paul.walmsley@...ive.com>,
	Palmer Dabbelt <palmer@...belt.com>,
	Albert Ou <aou@...s.berkeley.edu>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Len Brown <lenb@...nel.org>, Robert Moore <robert.moore@...el.com>,
	Conor Dooley <conor.dooley@...rochip.com>,
	Guo Ren <guoren@...nel.org>,
	Alexandre Ghiti <alexghiti@...osinc.com>,
	Greentime Hu <greentime.hu@...ive.com>,
	Charlie Jenkins <charlie@...osinc.com>,
	Sami Tolvanen <samitolvanen@...gle.com>,
	Zong Li <zong.li@...ive.com>, Jisheng Zhang <jszhang@...nel.org>,
	Baoquan He <bhe@...hat.com>,
	Clément Léger <cleger@...osinc.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Chen Jiahao <chenjiahao16@...wei.com>,
	Arnd Bergmann <arnd@...db.de>, James Morse <james.morse@....com>,
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>,
	Evan Green <evan@...osinc.com>,
	Samuel Holland <samuel.holland@...ive.com>,
	Marc Zyngier <maz@...nel.org>, Anup Patel <apatel@...tanamicro.com>,
	Tony Luck <tony.luck@...el.com>, Ard Biesheuvel <ardb@...nel.org>,
	Yuntao Wang <ytcoode@...il.com>,
	Alison Schofield <alison.schofield@...el.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-acpi@...r.kernel.org, acpica-devel@...ts.linux.dev
Subject: Re: [PATCH v2 6/6] ACPI: RISCV: Enable ACPI based NUMA

Hi Haibo,

On Thu, Mar 07, 2024 at 04:47:58PM +0800, Haibo Xu wrote:
> Enable ACPI based NUMA for RISCV in Kconfig.
> 
> Signed-off-by: Haibo Xu <haibo1.xu@...el.com>
> ---
>  arch/riscv/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index 0bfcfec67ed5..0fb55f166701 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -447,6 +447,7 @@ config NUMA
>  	select HAVE_SETUP_PER_CPU_AREA
>  	select NEED_PER_CPU_EMBED_FIRST_CHUNK
>  	select NEED_PER_CPU_PAGE_FIRST_CHUNK
> +	select ACPI_NUMA if ACPI

If the firmware didn't provide the SRAT/SLIT on ACPI based systems, then
there will be a message "Failed to initialise from firmware" from
arch_acpi_numa_init(). This is not specific to RISC-V. But I am
wondering why should it be pr_info instead of pr_debug.

Thanks,
Sunil
>  	select OF_NUMA
>  	select USE_PERCPU_NUMA_NODE_ID
>  	help
> -- 
> 2.34.1
>