lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 1 Apr 2024 15:41:58 +0800
From: Haibo Xu <xiaobo55x@...il.com>
To: Sunil V L <sunilvl@...tanamicro.com>
Cc: Haibo Xu <haibo1.xu@...el.com>, ajones@...tanamicro.com, 
	Paul Walmsley <paul.walmsley@...ive.com>, Palmer Dabbelt <palmer@...belt.com>, 
	Albert Ou <aou@...s.berkeley.edu>, "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>, 
	Robert Moore <robert.moore@...el.com>, Conor Dooley <conor.dooley@...rochip.com>, 
	Guo Ren <guoren@...nel.org>, Alexandre Ghiti <alexghiti@...osinc.com>, 
	Greentime Hu <greentime.hu@...ive.com>, Jisheng Zhang <jszhang@...nel.org>, 
	Baoquan He <bhe@...hat.com>, Sami Tolvanen <samitolvanen@...gle.com>, Zong Li <zong.li@...ive.com>, 
	Clément Léger <cleger@...osinc.com>, 
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Chen Jiahao <chenjiahao16@...wei.com>, 
	Arnd Bergmann <arnd@...db.de>, James Morse <james.morse@....com>, 
	"Russell King (Oracle)" <rmk+kernel@...linux.org.uk>, Evan Green <evan@...osinc.com>, 
	Samuel Holland <samuel.holland@...ive.com>, Marc Zyngier <maz@...nel.org>, 
	Anup Patel <apatel@...tanamicro.com>, Ard Biesheuvel <ardb@...nel.org>, 
	Tony Luck <tony.luck@...el.com>, Yuntao Wang <ytcoode@...il.com>, 
	Dave Hansen <dave.hansen@...ux.intel.com>, Alison Schofield <alison.schofield@...el.com>, 
	Dan Williams <dan.j.williams@...el.com>, linux-riscv@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-acpi@...r.kernel.org, 
	acpica-devel@...ts.linux.dev
Subject: Re: [PATCH v2 2/6] ACPI: RISCV: Add NUMA support based on SRAT and SLIT

On Mon, Apr 1, 2024 at 3:06 PM Sunil V L <sunilvl@...tanamicro.com> wrote:
>
> On Thu, Mar 07, 2024 at 04:47:54PM +0800, Haibo Xu wrote:
> > Add acpi_numa.c file to enable parse NUMA information from
> > ACPI SRAT and SLIT tables. SRAT table provide CPUs(Hart) and
> > memory nodes to proximity domain mapping, while SLIT table
> > provide the distance metrics between proximity domains.
> >
> > Signed-off-by: Haibo Xu <haibo1.xu@...el.com>
> > ---
> >  arch/riscv/include/asm/acpi.h |  15 +++-
> >  arch/riscv/kernel/Makefile    |   1 +
> >  arch/riscv/kernel/acpi.c      |   5 --
> >  arch/riscv/kernel/acpi_numa.c | 131 ++++++++++++++++++++++++++++++++++
> >  arch/riscv/kernel/setup.c     |   4 +-
> >  arch/riscv/kernel/smpboot.c   |   2 -
> >  include/linux/acpi.h          |   6 ++
> >  7 files changed, 154 insertions(+), 10 deletions(-)

> >  #ifndef PHYS_CPUID_INVALID
> >  typedef u32 phys_cpuid_t;
> >  #define PHYS_CPUID_INVALID (phys_cpuid_t)(-1)
> > --
> This is a large patch spanning across multiple files. Can we split this
> into multiple smaller patches? Changes look fine to me though.
>

Thanks for the review!
I will try to break them in v3.

> Reviewed-by: Sunil V L <sunilvl@...tanamicro.com>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ