linux-kernel - Re: [PATCH] staging: axis-fifo: Fix indentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Zgqn8izgsMI7rQNA@archie.me>
Date: Mon, 1 Apr 2024 19:26:26 +0700
From: Bagas Sanjaya <bagasdotme@...il.com>
To: me@...tyapps.xyz
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Prathu Baronia <prathubaronia2011@...il.com>,
	Rob Herring <robh@...nel.org>, Yangtao Li <frank.li@...o.com>,
	"Fabio M. De Francesco" <fmdefrancesco@...il.com>,
	Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
	Khadija Kamran <kamrankhadijadj@...il.com>,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: axis-fifo: Fix indentation

On Tue, Mar 05, 2024 at 11:14:01PM +0200, me@...tyapps.xyz wrote:
> From: Uri Arev <me@...tyapps.xyz>
> 
> Warning reported by checkpatch.pl script:
> 
> CHECK: Alignment should match open parenthesis
> 
> Signed-off-by: Uri Arev <me@...tyapps.xyz>
> ---
>  drivers/staging/axis-fifo/axis-fifo.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/staging/axis-fifo/axis-fifo.c b/drivers/staging/axis-fifo/axis-fifo.c
> index 727b956aa231..ab758a527261 100644
> --- a/drivers/staging/axis-fifo/axis-fifo.c
> +++ b/drivers/staging/axis-fifo/axis-fifo.c
> @@ -381,8 +381,8 @@ static ssize_t axis_fifo_read(struct file *f, char __user *buf,
>  		 */
>  		mutex_lock(&fifo->read_lock);
>  		ret = wait_event_interruptible_timeout(fifo->read_queue,
> -			ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> -			read_timeout);
> +						       ioread32(fifo->base_addr + XLLF_RDFO_OFFSET),
> +						       read_timeout);
>  
>  		if (ret <= 0) {
>  			if (ret == 0) {
> @@ -522,9 +522,9 @@ static ssize_t axis_fifo_write(struct file *f, const char __user *buf,
>  		 */
>  		mutex_lock(&fifo->write_lock);
>  		ret = wait_event_interruptible_timeout(fifo->write_queue,
> -			ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> -				 >= words_to_write,
> -			write_timeout);
> +						       ioread32(fifo->base_addr + XLLF_TDFV_OFFSET)
> +								>= words_to_write,
> +						       write_timeout);
>  
>  		if (ret <= 0) {
>  			if (ret == 0) {

LGTM, thanks!

Reviewed-by: Bagas Sanjaya <bagasdotme@...il.com>

-- 
An old man doll... just what I always wanted! - Clara

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)