linux-kernel - Re: [PATCH] PCI: apple: Fix dependency on 16kB pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86cyr9z2ot.wl-maz@kernel.org>
Date: Mon, 01 Apr 2024 13:29:22 +0100
From: Marc Zyngier <maz@...nel.org>
To: "Arnd Bergmann" <arnd@...db.de>
Cc: linux-pci@...r.kernel.org,	linux-kernel@...r.kernel.org,
	"Lorenzo Pieralisi" <lpieralisi@...nel.org>,	Krzysztof Wilczyński <kw@...ux.com>,	"Rob Herring" <robh@...nel.org>,
	"Bjorn Helgaas" <bhelgaas@...gle.com>
Subject: Re: [PATCH] PCI: apple: Fix dependency on 16kB pages

On Mon, 01 Apr 2024 13:23:27 +0100,
"Arnd Bergmann" <arnd@...db.de> wrote:
> 
> On Mon, Apr 1, 2024, at 14:19, Marc Zyngier wrote:
> > While d3e5bab923d3 consolidated the various definitions for page sizes,
> > it ended up breaking the Apple PCIe driver, which still depends on
> > ARM64_PAGE_SHIFT. Switch over to HAVE_PAGE_SIZE_16KB to make the driver
> > selectable again.
> >
> > Cc: Arnd Bergmann <arnd@...db.de>
> > Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
> > Cc: "Krzysztof Wilczyński" <kw@...ux.com>
> > Cc: Rob Herring <robh@...nel.org>
> > Cc: Bjorn Helgaas <bhelgaas@...gle.com>
> > Fixes: d3e5bab923d3 ("arch: simplify architecture specific page size 
> > configuration")
> > Signed-off-by: Marc Zyngier <maz@...nel.org>
> 
> The dependency only exists in the asahi kernel with commit
> db5709e83c11 ("PCI: apple: Add depends on ARM64_PAGE_SHIFT = 14")
> and is not present upstream.

You are absolutely right, and I should have checked where this
dependency was coming from.

Apologies for the noise.

	M.

-- 
Without deviation from the norm, progress is not possible.