lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Zgw881ApbwJrozAw@smile.fi.intel.com>
Date: Tue, 2 Apr 2024 20:14:27 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Hugo Villeneuve <hugo@...ovil.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org,
	Jiri Slaby <jirislaby@...nel.org>
Subject: Re: [PATCH v1 01/16] serial: max3100: Lock port->lock when calling
 uart_handle_cts_change()

On Tue, Apr 02, 2024 at 01:07:15PM -0400, Hugo Villeneuve wrote:
> On Tue,  2 Apr 2024 18:38:07 +0300
> Andy Shevchenko <andriy.shevchenko@...ux.intel.com> wrote:
> 
> Hi Andy,
> 
> > uart_handle_cts_change() has to be called with port lock taken,
> > Since we run it in a separate work, the lcok maybe not taken at
> 
> lcok -> lock
> 
> and possibly: "may not be taken" ?

Thanks, I'll fix this in case a new version is required.

> > the time of running. Make sure that it's taken by explicitly doing
> > that. Without it we got a splat:
> > 
> >   WARNING: CPU: 0 PID: 10 at drivers/tty/serial/serial_core.c:3491 uart_handle_cts_change+0xa6/0xb0
> >   ...
> >   Workqueue: max3100-0 max3100_work [max3100]
> >   RIP: 0010:uart_handle_cts_change+0xa6/0xb0
> >   ...
> >    max3100_handlerx+0xc5/0x110 [max3100]
> >    max3100_work+0x12a/0x340 [max3100]

-- 
With Best Regards,
Andy Shevchenko



Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ