linux-kernel - Re: [PATCH net-next v1 4/8] net: dsa: microchip: ksz8: Refactor ksz8_r_dyn_mac

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 2 Apr 2024 10:07:26 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: <Arun.Ramadoss@...rochip.com>
Cc: <andrew@...n.ch>, <olteanv@...il.com>, <davem@...emloft.net>,
 <Woojung.Huh@...rochip.com>, <pabeni@...hat.com>,
 <o.rempel@...gutronix.de>, <edumazet@...gle.com>, <f.fainelli@...il.com>,
 <kernel@...gutronix.de>, <san@...v.dk>, <linux-kernel@...r.kernel.org>,
 <netdev@...r.kernel.org>, <UNGLinuxDriver@...rochip.com>
Subject: Re: [PATCH net-next v1 4/8] net: dsa: microchip: ksz8: Refactor
 ksz8_r_dyn_mac_table() for readability

On Tue, 2 Apr 2024 15:44:30 +0000 Arun.Ramadoss@...rochip.com wrote:
> >         int rc;  
> 
> If rc is initialized with 0, we don't need to assign rc = 0 in the
> success path.

Not so sure -- it's easier for the compiler to catch uninitialized
variables than "accidentally stale" values.