linux-kernel - Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG_fn=XL7tSuCuBXKf1YDiETkFMte7JyLrSE+saDthtJj==hUQ@mail.gmail.com>
Date: Tue, 2 Apr 2024 09:04:09 +0200
From: Alexander Potapenko <glider@...gle.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: Peter Collingbourne <pcc@...gle.com>, Andrey Konovalov <andreyknvl@...il.com>, 
	Oscar Salvador <osalvador@...e.de>, Andrew Morton <akpm@...ux-foundation.org>, 
	linux-kernel@...r.kernel.org, linux-mm@...ck.org, 
	Michal Hocko <mhocko@...e.com>, Marco Elver <elver@...gle.com>, Omar Sandoval <osandov@...com>
Subject: Re: [PATCH] stackdepot: Rename pool_index to pool_index_plus_1

On Tue, Apr 2, 2024 at 8:54 AM Vlastimil Babka <vbabka@...e.cz> wrote:
>
> On 4/2/24 2:14 AM, Peter Collingbourne wrote:
> > Commit 3ee34eabac2a ("lib/stackdepot: fix first entry having a
> > 0-handle") changed the meaning of the pool_index field to mean "the
> > pool index plus 1". This made the code accessing this field less
> > self-documenting, as well as causing debuggers such as drgn to not
> > be able to easily remain compatible with both old and new kernels,
> > because they typically do that by testing for presence of the new
> > field. Because stackdepot is a debugging tool, we should make sure
> > that it is debugger friendly. Therefore, give the field a different
> > name to improve readability as well as enabling debugger backwards
> > compatibility.
> >
> > Signed-off-by: Peter Collingbourne <pcc@...gle.com>
> > Link: https://linux-review.googlesource.com/id/Ib3e70c36c1d230dd0a118dc22649b33e768b9f88
>
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
Reviewed-by: Alexander Potapenko <glider@...gle.com>