linux-kernel - Re: [PATCH] Staging: rtl8723bs: remove spaces before tabs in rtw_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e26e8d4b-ce02-497f-a015-c2d2eab9bda2@moroto.mountain>
Date: Tue, 2 Apr 2024 10:05:07 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Meir Elisha <meir6264@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Yang Yingliang <yangyingliang@...wei.com>,
	Ruan Jinjie <ruanjinjie@...wei.com>, linux-staging@...ts.linux.dev,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8723bs: remove spaces before tabs in
 rtw_set_key()

On Fri, Mar 29, 2024 at 06:09:53PM +0300, Meir Elisha wrote:
> Remove spaces before tabs in order to improve coding style.
> 
> Signed-off-by: Meir Elisha <meir6264@...il.com>
> ---
>  drivers/staging/rtl8723bs/core/rtw_mlme.c | 36 +++++++++++------------
>  1 file changed, 18 insertions(+), 18 deletions(-)
> 
> diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> index bfb27f902753..5a506fe4698b 100644
> --- a/drivers/staging/rtl8723bs/core/rtw_mlme.c
> +++ b/drivers/staging/rtl8723bs/core/rtw_mlme.c
> @@ -626,10 +626,10 @@ void rtw_add_network(struct adapter *adapter, struct wlan_bssid_ex *pnetwork)
>  
>  /* select the desired network based on the capability of the (i)bss. */
>  /*  check items: (1) security */
> -/* 			   (2) network_type */
> -/* 			   (3) WMM */
> -/* 			   (4) HT */
> -/*                      (5) others */
> +/* (2) network_type */
> +/* (3) WMM */
> +/* (4) HT */
> +/* (5) others */

This comment looks weird.

>  int rtw_is_desired_network(struct adapter *adapter, struct wlan_network *pnetwork);
>  int rtw_is_desired_network(struct adapter *adapter, struct wlan_network *pnetwork)
>  {
> @@ -1052,9 +1052,9 @@ static struct sta_info *rtw_joinbss_update_stainfo(struct adapter *padapter, str
>  			memset((u8 *)&psta->dot11rxpn, 0, sizeof(union pn48));
>  		}
>  
> -		/* 	Commented by Albert 2012/07/21 */
> -		/* 	When doing the WPS, the wps_ie_len won't equal to 0 */
> -		/* 	And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */
> +		/* Commented by Albert 2012/07/21 */

Nobody knows who Albert is.

> +		/* When doing the WPS, the wps_ie_len won't equal to 0 */
> +		/* And the Wi-Fi driver shouldn't allow the data packet to be transmitted. */
>  		if (padapter->securitypriv.wps_ie_len != 0) {
>  			psta->ieee8021x_blocked = true;
>  			padapter->securitypriv.wps_ie_len = 0;
> @@ -1916,7 +1916,7 @@ signed int rtw_set_key(struct adapter *adapter, struct security_priv *psecurityp
>  	u8 keylen;
>  	struct cmd_obj		*pcmd;
>  	struct setkey_parm	*psetkeyparm;
> -	struct cmd_priv 	*pcmdpriv = &(adapter->cmdpriv);
> +	struct cmd_priv *pcmdpriv = &(adapter->cmdpriv);
>  	signed int	res = _SUCCESS;

These declarations look bad.

>  
>  	psetkeyparm = rtw_zmalloc(sizeof(struct setkey_parm));
> @@ -2021,8 +2021,8 @@ int rtw_restruct_wmm_ie(struct adapter *adapter, u8 *in_ie, u8 *out_ie, uint in_
>  /*  */
>  /*  Search by BSSID, */
>  /*  Return Value: */
> -/* 		-1		:if there is no pre-auth key in the  table */
> -/* 		>= 0		:if there is pre-auth key, and   return the entry id */
> +/* -1: if there is no pre-auth key in the  table */
> +/* >= 0: if there is pre-auth key, and   return the entry id */
>  /*  */
>  /*  */

Bad.

Nobody really cares about spaces before tabs.  The more important thing
is that it looks ugly.  Focus on what matters more.

regards,
dan carpenter