linux-kernel - Re: [PATCH v7] posix-timers: add clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87il10ce1g.ffs@tglx>
Date: Tue, 02 Apr 2024 11:24:59 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Mahesh Bandewar (महेश बंडेवार) <maheshb@...gle.com>
Cc: Sagi Maimon <maimon.sagi@...il.com>, richardcochran@...il.com,
 luto@...nel.org, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com, x86@...nel.org, hpa@...or.com, arnd@...db.de,
 geert@...ux-m68k.org, peterz@...radead.org, hannes@...xchg.org,
 sohil.mehta@...el.com, rick.p.edgecombe@...el.com, nphamcs@...il.com,
 palmer@...ive.com, keescook@...omium.org, legion@...nel.org,
 mark.rutland@....com, mszeredi@...hat.com, casey@...aufler-ca.com,
 reibax@...il.com, davem@...emloft.net, brauner@...nel.org,
 linux-kernel@...r.kernel.org, linux-api@...r.kernel.org,
 linux-arch@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH v7] posix-timers: add clock_compare system call

On Mon, Apr 01 2024 at 22:42, Mahesh Bandewar (महेश बंडेवार) wrote:
> On Mon, Apr 1, 2024 at 1:46 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>> So if there is a backwards compability issue with PTP_SYS_OFFSET2, then
>> you need to introduce PTP_SYS_OFFSET3. The PTP_SYS_*2 variants were
>> introduced to avoid backwards compatibility issues as well, but
>> unfortunately that did not address the reserved fields problem for
>> PTP_SYS_OFFSET2. PTP_SYS_OFFSET_EXTENDED2 should just work, but maybe
>> the PTP maintainers want a full extension to '3'. Either way is fine.
>>
> https://patchwork.kernel.org/project/netdevbpf/patch/20240104212436.3276057-1-maheshb@google.com/
>
> This was my attempt to solve a similar issue with the new ioctl op to
> avoid backward compatibility issues.  Instead of flags I used the
> clockid_t in a similar fashion.

Works as well. I'm not seing the point for CLOCK_MONOTONIC and the
change logs are not really telling anything about the problem being
solved....

Thanks,

        tglx