linux-kernel - Re: [PATCH v2 4/7] riscv: Simplify text patching loops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87h6gkrp8o.fsf@all.your.base.are.belong.to.us>
Date: Tue, 02 Apr 2024 13:13:59 +0200
From: Björn Töpel <bjorn@...nel.org>
To: Samuel Holland <samuel.holland@...ive.com>, Palmer Dabbelt
 <palmer@...belt.com>
Cc: Björn Töpel <bjorn@...osinc.com>,
 linux-riscv@...ts.infradead.org,
 linux-kernel@...r.kernel.org, Samuel Holland <samuel.holland@...ive.com>
Subject: Re: [PATCH v2 4/7] riscv: Simplify text patching loops

Samuel Holland <samuel.holland@...ive.com> writes:

> This reduces the number of variables and makes the code easier to parse.
>
> Signed-off-by: Samuel Holland <samuel.holland@...ive.com>
> ---
>
> Changes in v2:
>  - Further simplify patch_insn_set()/patch_insn_write() loop conditions
>  - Use min() instead of min_t() since both sides are unsigned long

Thanks for addressing the changes! Nice cleanup!

Reviewed-by: Björn Töpel <bjorn@...osinc.com>