lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240402142146.58a438c9@collabora.com>
Date: Tue, 2 Apr 2024 14:21:46 +0200
From: Boris Brezillon <boris.brezillon@...labora.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Steven Price <steven.price@....com>, Liviu Dudau <liviu.dudau@....com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Grant Likely
 <grant.likely@...aro.org>, Heiko Stuebner <heiko@...ech.de>,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] drm/panthor: Fix a couple -ENOMEM error codes

On Tue, 2 Apr 2024 12:58:09 +0300
Dan Carpenter <dan.carpenter@...aro.org> wrote:

> These error paths forgot to set the error code to -ENOMEM.
> 
> Fixes: 647810ec2476 ("drm/panthor: Add the MMU/VM logical block")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Boris Brezillon <boris.brezillon@...labora.com>

> ---
>  drivers/gpu/drm/panthor/panthor_mmu.c | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panthor/panthor_mmu.c b/drivers/gpu/drm/panthor/panthor_mmu.c
> index fdd35249169f..a26b40aab261 100644
> --- a/drivers/gpu/drm/panthor/panthor_mmu.c
> +++ b/drivers/gpu/drm/panthor/panthor_mmu.c
> @@ -1264,8 +1264,10 @@ static int panthor_vm_prepare_map_op_ctx(struct panthor_vm_op_ctx *op_ctx,
>  	op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
>  						 sizeof(*op_ctx->rsvd_page_tables.pages),
>  						 GFP_KERNEL);
> -	if (!op_ctx->rsvd_page_tables.pages)
> +	if (!op_ctx->rsvd_page_tables.pages) {
> +		ret = -ENOMEM;
>  		goto err_cleanup;
> +	}
>  
>  	ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
>  				    op_ctx->rsvd_page_tables.pages);
> @@ -1318,8 +1320,10 @@ static int panthor_vm_prepare_unmap_op_ctx(struct panthor_vm_op_ctx *op_ctx,
>  		op_ctx->rsvd_page_tables.pages = kcalloc(pt_count,
>  							 sizeof(*op_ctx->rsvd_page_tables.pages),
>  							 GFP_KERNEL);
> -		if (!op_ctx->rsvd_page_tables.pages)
> +		if (!op_ctx->rsvd_page_tables.pages) {
> +			ret = -ENOMEM;
>  			goto err_cleanup;
> +		}
>  
>  		ret = kmem_cache_alloc_bulk(pt_cache, GFP_KERNEL, pt_count,
>  					    op_ctx->rsvd_page_tables.pages);


Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ