linux-kernel - Re: [PATCH v2 0/5] HID: playstation: DS4: LED bugfix, third-party gamepad support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEc3jaBvM6zVAqecUaxbtwUOTni4yT0wum_5ab5N1DLVYvhOeQ@mail.gmail.com>
Date: Wed, 3 Apr 2024 12:24:26 -0700
From: Roderick Colenbrander <thunderbird2k@...il.com>
To: Jiri Kosina <jikos@...nel.org>
Cc: Max Staudt <max@...as.org>, Roderick Colenbrander <roderick.colenbrander@...y.com>, 
	Benjamin Tissoires <benjamin.tissoires@...hat.com>, linux-input@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/5] HID: playstation: DS4: LED bugfix, third-party
 gamepad support

On Wed, Apr 3, 2024 at 11:11 AM Jiri Kosina <jikos@...nel.org> wrote:
>
> On Tue, 27 Feb 2024, Jiri Kosina wrote:
>
> > > Dear hid-playstation maintainers,
> > >
> > > Here is v2 of my patch series, with the discussed changes.
> > >
> > >
> > > Differences since v1:
> > >  - Dropped patch for 7545:0104 (SZ-MYPOWER controllers)
> > >  - Dropped patch for DS4 clones without a MAC address on USB
> > >  - Changed hid_err() to hid_warn() where things are no longer fatal
> > >  - Simplified goto as return in minimal report parsing
> > >
> > >
> > > I've included the patch to simplify the PID/VID mapping to controller
> > > types, since the previous discussion made it sound useful for future
> > > support of second-party controllers. Please feel free to drop it if you
> > > don't think it's relevant now.
> > >
> > >
> > > Thanks for your feedback!
> > >
> > > Max
> > >
> > >
> > > Patches in this series:
> > >   [PATCH v2 1/5] HID: playstation: DS4: Fix LED blinking
> > >   [PATCH v2 2/5] HID: playstation: DS4: Don't fail on FW/HW version
> > >   [PATCH v2 3/5] HID: playstation: DS4: Don't fail on calibration data
> > >   [PATCH v2 4/5] HID: playstation: DS4: Parse minimal report 0x01
> > >   [PATCH v2 5/5] HID: playstation: Simplify device type ID
> >
> > Roderick, any word on this series please?
>
> Roderick, please speak up now, or I'll queue this as-is for 6.10 in the
> coming few days. Thanks,
>
> --
> Jiri Kosina
> SUSE Labs
>

Hi Jiri,

Sorry for late reply, let's merge it. There are maybe 1-2 nitpicky
things I forgot to email about, but I can deal with those later if I
feel it is needed down the road.

Thanks,
Roderick