linux-kernel - Re: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <78731619-58a3-406b-9112-5eb991bc6e7e@app.fastmail.com>
Date: Wed, 03 Apr 2024 10:50:57 +0200
From: "Arnd Bergmann" <arnd@...db.de>
To: "Damien Le Moal" <dlemoal@...nel.org>, "Arnd Bergmann" <arnd@...nel.org>,
 linux-kernel@...r.kernel.org, "Niklas Cassel" <cassel@...nel.org>,
 "Saeed Bishara" <saeed@...ntu-saeed.il.marvell.com>
Cc: "Ma Ke" <make_ruc2021@....com>,
 Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
 "Sergey Shtylyov" <s.shtylyov@....ru>,
 "Christophe JAILLET" <christophe.jaillet@...adoo.fr>,
 "Jeff Garzik" <jeff@...zik.org>, linux-ide@...r.kernel.org
Subject: Re: [PATCH 30/34] sata: mv: drop unnecessary #ifdef checks

On Wed, Apr 3, 2024, at 10:32, Damien Le Moal wrote:
> On 4/3/24 17:06, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> Building with W=1 shows a warning for an unused variable when CONFIG_PCI
>> is diabled:
>> 
>> drivers/ata/sata_mv.c:790:35: error: unused variable 'mv_pci_tbl' [-Werror,-Wunused-const-variable]
>> static const struct pci_device_id mv_pci_tbl[] = {
>> 
>> Move the table into the same block that containsn the pci_driver
>> definition.
>> 
>> Fixes: 7bb3c5290ca0 ("sata_mv: Remove PCI dependency")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>
> The patch title is also not describing what the patch does.
> Are you OK with changing that to:
>
> ata: sata_mv: Fix PCI device ID table declaration warning
>
> ?

Yes, please do, thanks!

I had first tried to remove all the #ifdef checks and just
rely on dead-code-elimination doing the same when
pci_register_driver() is stubbed out and IS_ENABLED(CONFIG_OF)
checks turn off the rest. Unfortunately, the include/linux/pci.h
interfaces are not all stubbed out here and cause compile-time
failures without CONFIG_PCI, so that didn't work out.

     Arnd